Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify JobStatus and RunStatus enums across components #324

Open
VMois opened this issue Dec 20, 2021 · 2 comments
Open

Unify JobStatus and RunStatus enums across components #324

VMois opened this issue Dec 20, 2021 · 2 comments

Comments

@VMois
Copy link

VMois commented Dec 20, 2021

Currently, JobStatus (enumeration of possible job statuses) and RunStatus (enumeration of possible workflow statuses) reside in reana-db repo. But, the values that represent job and workflow statuses are used by workflow-engines and, as of now, are duplicated in each of them. The engines do not depend on reana-db so they cannot import those enums.

What do you think if we move JobStatus and RunStatus enums from reana-db to reana-commons repo? How will it affect future maintenance of engines, reana-db and reana-commons repositories?

Originated in this PR

@VMois VMois changed the title Add JobStatus and RunStatus Enums Add JobStatus and RunStatus enums Dec 20, 2021
@VMois
Copy link
Author

VMois commented Dec 20, 2021

In addition, r-job-controller is returning started JobStatus which is not listed in reana-db, reanahub/reana-job-controller#337.

@VMois
Copy link
Author

VMois commented Jan 10, 2022

Related issue reanahub/reana-workflow-controller/issues/204 which lists adding enums to r-commons as a possible solution.

@VMois VMois changed the title Add JobStatus and RunStatus enums Unify JobStatus and RunStatus enums across components Jan 12, 2022
@VMois VMois added the type/rfc label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant