fixtures: shared volume path through env variable #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
rc-217/configurable-shared-volume-path
branch
from
801c73a
to
64d1d7c
Compare
diegodelemos
commented
Oct 13, 2020
| temp_path = str(tmpdir_factory.mktemp("reana")) | ||
| yield temp_path | ||
| shutil.rmtree(temp_path) | ||
| shared_volume_path = os.getenv("SHARED_VOLUME_PATH", "") |
There was a problem hiding this comment.
See how this is being used in reanahub/reana-workflow-controller#338 (this line).
diegodelemos
force-pushed
the
rc-217/configurable-shared-volume-path
branch
from
64d1d7c
to
8ec4056
Compare
diegodelemos
commented
Oct 14, 2020
| """Create a sample workflow in the database. | ||
|
|
||
| Scope: function | ||
|
|
||
| Adds a sample serial workflow in the DB. | ||
| """ | ||
| from reana_db.models import Workflow |
There was a problem hiding this comment.
Moved REANA-DB imports form global scope to the fixtures to make REANA-Client pass on Python2.7 builds, currently failing because of this.
There was a problem hiding this comment.
I think you're missing Base import in app fixture.
added 2 commits
October 15, 2020 12:17
* Avoids side effects when importing `pytest-reana` into REANA packages that do not depend on REANA-DB (e.g. REANA-Client) where incompatibilities such as using `f-strings` in REANA-DB and REANA-Client supporting Python2.7 are not compatible at import time.
diegodelemos
force-pushed
the
rc-217/configurable-shared-volume-path
branch
from
8ec4056
to
1a83daa
Compare
mvidalgarcia
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
r-w-c tests successfully passed locally together with reanahub/reana-commons#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-commons#217.