Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate: private gitlab environment images #478

Open
mvidalgarcia opened this issue Mar 17, 2021 · 1 comment
Open

validate: private gitlab environment images #478

mvidalgarcia opened this issue Mar 17, 2021 · 1 comment

Comments

@mvidalgarcia
Copy link
Member

mvidalgarcia commented Mar 17, 2021

$ reana-client validate --environments
  • Image existence check of public GitLab CERN images is addressed in validate: make image discovery more flexible #476.

  • Private images check is still missing. One needs to create a Personal Access token in the GitLab UI to pass it as a PRIVATE-TOKEN Header to be able to access this information. This token is rather sensible information that can't be easily plugged into the reana-client so we must think of a smart solution. Possible solutions:

    • A) Add --gitlab-private flag or similar where the user can pass their private token to perform the checks.
    • B) Skip private image validation on reana-client altogether and face this on the cluster-side where we can save the REANA GitLab token as a secret.
    • C) Other ideas?

Originally posted by @mvidalgarcia in #463 (comment)

@mvidalgarcia
Copy link
Member Author

As we're moving towards having a thinner client and moving all the logic to the server-side, option B) gains more relevance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant