Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: do not show db errors #411

Open
diegodelemos opened this issue Apr 21, 2020 · 0 comments
Open

cli: do not show db errors #411

diegodelemos opened this issue Apr 21, 2020 · 0 comments

Comments

@diegodelemos
Copy link
Member

Currently, if there is something wrong with the database, either a connection problem or a query problem, we show the psycop2 stack trace which always leaks information (DB username, table and field names...). We should give more user-friendly and secure errors.

$ # edit R-DB deployment to use a different password (it is set as env variable)
$ # this will redeploy R-DB with a password different to the one loaded in RS and RWC
$ reana-client run
[INFO] Creating a workflow...
Cannot create workflow : 
(psycopg2.OperationalError) FATAL:  password authentication failed for user "reana"

(Background on this error at: http://sqlalche.me/e/e3q8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant