Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add an (opt in) update check to SwiftLint #5551

Open
mildm8nnered opened this issue Apr 30, 2024 · 2 comments
Open

Feature request: Add an (opt in) update check to SwiftLint #5551

mildm8nnered opened this issue Apr 30, 2024 · 2 comments
Labels
enhancement integration Issues related to integration of SwiftLint into toolchains.

Comments

@mildm8nnered
Copy link
Collaborator

Periphery has an (opt-out) update check: --disable-update-check

I'm not sure how happy I'd be with an opt out network access, but I think a lot of people aren't updating SwiftLint that often (which is a shame because there are a lot of great new rules, bug fixes, and general improvements in every release), and at least offering the option of an opt-in update check would help those users who enabled it to be alerted to new versions.

I've not looked into what we could check - GitHub would be easiest maybe. Probably on a fast timeout, so as not to interfere with people's builds.

@SimplyDanny SimplyDanny added enhancement integration Issues related to integration of SwiftLint into toolchains. labels May 1, 2024
@SimplyDanny
Copy link
Collaborator

I agree that having this check on by default might not be everybody's favorite. Yet, if one needs to explicitly opt-in with an argument when running swiftlint to perform the check feels the same like having no check at all. An option in the configuration might be a good middle course, though.

@mildm8nnered
Copy link
Collaborator Author

So config file option - I think these should kind of be standard for most command line options anyway - that would help with awareness.

While this would be useless at first when no-one's using it, at least it would be there, and we can build up awareness over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement integration Issues related to integration of SwiftLint into toolchains.
Projects
None yet
Development

No branches or pull requests

2 participants