Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make implicitly confirming to Actor to trigger warning #5465

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make implicitly confirming to Actor to trigger warning #5465

wants to merge 4 commits into from

Conversation

marunomi
Copy link
Contributor

This PR will resolve #5422 by adding checking for implicitly confirming to Actor protocol.

Before the validate function, I used visitPost(_ node: ActorDeclSyntax) to determine if the actor keyword is used.
I wrote it this way because I could not determine within the missingDocOffsets function whether the actor keyword is used or not.

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 10, 2024 •
edited

55 Messages
📖 Linting Aerial with this PR took 0.72s vs 0.71s on main (1% slower)
📖 Linting Alamofire with this PR took 1.02s vs 1.04s on main (1% faster)
📖 Linting Brave with this PR took 5.85s vs 5.88s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 3.06s vs 3.03s on main (0% slower)
📖 Linting Firefox with this PR took 7.76s vs 7.98s on main (2% faster)
📖 Linting Kickstarter with this PR took 7.22s vs 7.09s on main (1% slower)
📖 Linting Moya with this PR took 0.43s vs 0.44s on main (2% faster)
📖 Linting NetNewsWire with this PR took 2.06s vs 2.05s on main (0% slower)
📖 Linting Nimble with this PR took 0.6s vs 0.6s on main (0% slower)
📖 Linting PocketCasts with this PR took 5.85s vs 5.81s on main (0% slower)
📖 Linting Quick with this PR took 0.28s vs 0.29s on main (3% faster)
📖 Linting Realm with this PR took 3.67s vs 3.71s on main (1% faster)
📖 Linting Sourcery with this PR took 1.75s vs 1.75s on main (0% slower)
📖 Linting Swift with this PR took 3.42s vs 3.47s on main (1% faster)
📖 Linting VLC with this PR took 0.98s vs 0.96s on main (2% slower)
📖 Linting Wire with this PR took 12.43s vs 12.53s on main (0% faster)
📖 Linting WordPress with this PR took 8.28s vs 8.26s on main (0% slower)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/Helpers/LaunchHelper.swift:14:10: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Brave: /Sources/Brave/WebFilters/ContentBlocker/ContentBlockerManager.swift:138:10: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockStats.swift:15:10: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/TabDataStore/TabDataStore.swift:8:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/TabDataStore/TabSessionStore.swift:8:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Firefox: /firefox-ios/Push/Autopush.swift:10:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Firefox: /firefox-ios/Push/Autopush.swift:52:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Firefox: /firefox-ios/Push/Autopush.swift:55:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Firefox: /firefox-ios/Storage/DiskImageStore.swift:15:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:126:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:138:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:144:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:150:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:158:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:60:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:67:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:88:14: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileLog.swift:94:12: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/CommitSender.swift:24:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/CommitSender.swift:26:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/CommitSender.swift:31:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/CommitSender.swift:36:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/CoreCryptoProvider.swift:23:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:23:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:25:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:26:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:27:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:28:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:29:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:30:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSActionExecutor.swift:31:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSService.swift:1808:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSService.swift:1810:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/MLSService.swift:1811:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/SubconversationGroupIDRepository.swift:22:8: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/SubconversationGroupIDRepository.swift:24:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/SubconversationGroupIDRepository.swift:30:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/MLS/SubconversationGroupIDRepository.swift:35:5: warning: Missing Docs Violation: public declarations should be documented (missing_docs)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresluis1 andresluis1 andresluis1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing_docs warns about actors not documenting public protocol properties
3 participants
@marunomi @SwiftLintBot @andresluis1