pdf cut off long code in code block

[spxvszero]

No description provided.

[realdennis]

Thanks for your feedback, could you reproduce this bug and tell me the browser details?

[spxvszero]

like this

[nilesr]

Also interested in seeing this changed. If I can get it working locally I will submit a PR. I unfortunately need to submit an assignment as a PDF which includes a hand-written regular expression that is 541 characters long. I definitely need code blocks to wrap or it will get cut out.

[nilesr]

So by changing the rule in github-markdown.css line 706 from white-space: pre to white-space: pre-wrap will wrap text correctly. It is matched by a selector on line 700, .markdown-body pre>code.

I would make a pull request to add a simple checkbox to the left of the "Choose" button to toggle wrapping code blocks, but I couldn't get it to start locally with just an npm i and npm start, I get this error

./node_modules/create-event-target-hook/dist/index.mjs
Can't import the named export 'useCallback' from non EcmaScript module (only default export is available)

I don't have enough experience with react applications to figure out how to fix it, so I'm just going to apply the style in the devtools to export my current assignment. It does work correctly, even after exporting to PDF.

Before:

After:

These are both screenshots of my PDF reader, after export.

[miku86]

Hey there,

I can reproduce @nilesr post,
got this error too.

Reproduction:

• git clone [email protected]:realdennis/md2pdf.git
• cd md2pdf
• npm i
• npm start

./node_modules/create-event-target-hook/dist/index.mjs
Can't import the named export 'useCallback' from non EcmaScript module (only default export is available)

---

OS: Arch Linux 5.4.58-1-lts
Node: v12.18.3

---

I updated the version of create-event-target-hook from 1.2.2 to 1.3.1, but that didn't work.

In the end, I solved it by:

• index.js: L11: remove import createEventTargetHook from 'create-event-target-hook';
• index.js: L12: remove const useWindowEvent = createEventTargetHook(window);
• index.js: L23: remove useWindowEvent('mouseup', () => setDrag(false));

Greetings
Michael

[realdennis]

@nilesr @miku86 seems it's the issue in my dependency which is also owned by me, will figure out how fix, and update later, sorry for lately reply, and thanks for your kindly help!

[realdennis]

There's a quick hot fix to workaround this issue when develop

change here

md2pdf/src/App/Components/Markdown/index.js

Line 11 in 9bfa0e4

import createEventTargetHook from 'create-event-target-hook';

- import createEventTargetHook from 'create-event-target-hook';
+ import createEventTargetHook from 'create-event-target-hook/dist/index.js';

Not really sure why it uses emodule when develop, it's supposed to run build before, you can just workaround or check if there's a outdated react-scripts or somehow, feel free to pull the request.

It works on node v10.

[hacklschorsch]

Please don't add an option, just fix it with a good default instead.
Having too many options is what screws up most FLOSS app's usability.