From 96aee681497269a0ff2c0ff11ffc464f8a113cc8 Mon Sep 17 00:00:00 2001 From: Ron Hough Date: Wed, 21 Aug 2024 18:42:37 -0500 Subject: [PATCH] build: Retry logictests in integration build on failure The logictests have some irregular failures that often do not recur on retries. Since the test runs are short in integration builds, go ahead and retry on test failure in the event they'll clear up on their own. Change-Id: Ibc41744274fcd8514804625408cbbd479da7bd7c --- .buildkite/pipeline.public-common.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.buildkite/pipeline.public-common.yml b/.buildkite/pipeline.public-common.yml index 2b5a67ba41..cc9d677b63 100644 --- a/.buildkite/pipeline.public-common.yml +++ b/.buildkite/pipeline.public-common.yml @@ -9,6 +9,18 @@ common_values: - exit_status: -1 # agent timed out signal_reason: none limit: 3 + # It would be great to avoid duplication here, but yaml apparently does not + # support merging lists, only dictionaries: + retry_on_kill_or_test_fail: &retry_on_agent_kill_or_test_fail + automatic: + - signal_reason: agent_stop # spot instance killed by AWS + limit: 3 + - exit_status: -1 # agent timed out + signal_reason: none + limit: 3 + - exit_status: 101 # test failure + limit: 3 + steps: - label: ':rust: Check rustfmt' @@ -136,7 +148,7 @@ steps: - ecr#v2.7.0: login: true retries: 3 - retry: *retry_on_agent_kill + retry: *retry_on_agent_kill_or_test_fail - label: 'Test benchmark framework' key: test-benchmark