Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table with delimiter inside a comment fail to parse #1373

Open
altmannmarcelo opened this issue Sep 20, 2024 · 1 comment
Open

Table with delimiter inside a comment fail to parse #1373

altmannmarcelo opened this issue Sep 20, 2024 · 1 comment
Labels
bug Something isn't working Customer Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Milestone

Comments

@altmannmarcelo
Copy link
Contributor

Description

DDL that have delimiter inside comment fail to parse:

CREATE TABLE t (status tinyint COMMENT '1=active; 0=inactive');

fails with:

2024-09-20T15:18:37.116392Z  WARN taking database snapshot: replicators::mysql_connector::snapshot: Error extending CREATE TABLE "test"."t", table will not be used error=Query failed to parse: 0=inactive'
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci

Change in user-visible behavior

Requires documentation change

@altmannmarcelo altmannmarcelo added the Customer Created by Linear-GitHub Sync label Sep 20, 2024
@altmannmarcelo
Copy link
Contributor Author

Issue seems in ends_in_semicolon_or_eof as we are not considering to discard the semicolon if we it is inside a single or double quote.

@altmannmarcelo altmannmarcelo added this to the v.43 milestone Sep 20, 2024
@altmannmarcelo altmannmarcelo added High priority Created by Linear-GitHub Sync bug Something isn't working labels Sep 20, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.43, v.44, v.45 Sep 23, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.45, v.46 Oct 7, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.46, v.47, v.48 Oct 14, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.48, v.49 Oct 28, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.49, v.50 Nov 4, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.50, v.51, v.52 Nov 11, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.52, v.53 Nov 25, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.53, v.54 Dec 2, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.54, v.55 Dec 9, 2024
@altmannmarcelo altmannmarcelo added this to the v.56 milestone Dec 16, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.56, v.57 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Customer Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant