{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":495863734,"defaultBranch":"main","name":"readyset","ownerLogin":"readysettech","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-05-24T14:39:20.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/71727599?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718142452.0","currentOid":""},"activityList":{"items":[{"before":"c43ceb6d7ae379bcf1aefbc425ae72dfddfa4c65","after":"90d5d6d2d8979f2ae3435945507a07763009dd7a","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-12T19:46:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"4e6138ceb21d98ed8f05eecb232f240cc2e26543","after":"c43ceb6d7ae379bcf1aefbc425ae72dfddfa4c65","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-12T18:15:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"5bc079b8f3d6d080b4f4e1396e5db9705720007d","after":"4e6138ceb21d98ed8f05eecb232f240cc2e26543","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-12T17:32:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"587f4bd3ae5deb45f3d5a7b07f5ca222e296fb8d","after":"34e21918d1b3388645e419fb965fa4048ba205b4","ref":"refs/heads/I7c09688821e412c7ddd475e9bc4d2238ca56bff8","pushedAt":"2024-06-12T13:45:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"replicators: Add DDL vertical tests for MySQL\n\nThis commit adds DDL vertical tests for MySQL. The tests are a copy\nof the PostgreSQL tests, with the necessary changes to make them work\nand remove the unnecessary build of custom ENUM types which are not\nsupported to MySQL.\n\nThis commit also fixes REA-4453 by removing the views which we can\nquery when a new column is added to MySQL table.\n\nThis is the initial version that will be used to replay failures.\n\nRef: REA-4453\nFixes: #1271\n\nChange-Id: I7c09688821e412c7ddd475e9bc4d2238ca56bff8","shortMessageHtmlLink":"replicators: Add DDL vertical tests for MySQL"}},{"before":"e22172958a8741188a353a90e7a02e95e37fe6cc","after":"383d1e393b65a51f6d1a8b279a17e38527485e82","ref":"refs/heads/Ia217ccb2758441969af5b38899feccb39b3d60e9","pushedAt":"2024-06-12T11:25:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation of join that rely on generated columns\nscan the left side of the join and search the rows on the right side\nby scanning all rows in the right side O(n*m). This is not optimal.\n\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join operation to O(n).\n\nWe taken into consideration that the right side might have duplicated\nrows and we build a list of rows for each key in the hash table.\n\nRelease-Note-Core: Implemented Hash Join capability for Join's using\n generated columns, resulting in drastically increase of performance\n for those join operations.\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9\nReviewed-on: https://gerrit.readyset.name/c/readyset/+/7582\nTested-by: Buildkite CI\nReviewed-by: Vassili Zarouba \nReviewed-by: Michael Zink ","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":"6b74964a61f88d8feb4f37a6d73dcbcdd5ba3100","after":"5bc079b8f3d6d080b4f4e1396e5db9705720007d","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T22:36:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"d9131b289749e588ba988886aaa08b659bc9b6e3","after":"6b74964a61f88d8feb4f37a6d73dcbcdd5ba3100","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T22:23:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"82c61fccabc4ae5eeed21fb9e1a54514fe4d98a9","after":"d9131b289749e588ba988886aaa08b659bc9b6e3","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T22:20:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"5343059a165ee9127f400b4113cd44bb70e31584","after":"2d58329f03a04b10762560178501d5f16f5b82ba","ref":"refs/heads/I85fcf99449a14e9ddfc9e82020e08183cb552fd6","pushedAt":"2024-06-11T22:15:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"nom-sql: Parse bit string literals as BitVec\n\nWe were doing extraneous padding every time we turn a `BitVec` into\nbytes, resulting in incorrect predication on caches created with\nparameters on `BIT` columns.\n\nWe also improve bitvec resultset type support in logictests and add a\ntest that previously failed on Postgres. (The equivalent MySQL test is\nstill failing due to REA-3381.)\n\nChange-Id: I85fcf99449a14e9ddfc9e82020e08183cb552fd6","shortMessageHtmlLink":"nom-sql: Parse bit string literals as BitVec"}},{"before":"be2dbddc8b58db1e93317dd768cd3fe9172e3a00","after":"5343059a165ee9127f400b4113cd44bb70e31584","ref":"refs/heads/I85fcf99449a14e9ddfc9e82020e08183cb552fd6","pushedAt":"2024-06-11T21:50:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"nom-sql: Parse bit string literals as BitVec\n\nWe were doing extraneous padding every time we turn a `BitVec` into\nbytes, resulting in incorrect predication on caches created with\nparameters on `BIT` columns.\n\nWe also improve bitvec resultset type support in logictests and add a\ntest that previously failed on Postgres. (The equivalent MySQL test is\nstill failing due to REA-3381.)\n\nChange-Id: I85fcf99449a14e9ddfc9e82020e08183cb552fd6","shortMessageHtmlLink":"nom-sql: Parse bit string literals as BitVec"}},{"before":null,"after":"be2dbddc8b58db1e93317dd768cd3fe9172e3a00","ref":"refs/heads/I85fcf99449a14e9ddfc9e82020e08183cb552fd6","pushedAt":"2024-06-11T21:47:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"sql: Parse bit string literals as BitVec\n\nWe were doing extraneous padding every time we turn a `BitVec` into\nbytes, resulting in incorrect predication on caches created with\nparameters on `BIT` columns.\n\nWe also improve bitvec resultset type support in logictests and add a\ntest that previously failed on Postgres. (The equivalent MySQL test is\nstill failing due to REA-3381.)\n\nChange-Id: I85fcf99449a14e9ddfc9e82020e08183cb552fd6","shortMessageHtmlLink":"sql: Parse bit string literals as BitVec"}},{"before":"08e4d09ec2b8c3e515ce20a632be98f67a8fca39","after":"82c61fccabc4ae5eeed21fb9e1a54514fe4d98a9","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T21:42:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"f8c4508afe59248352af8cf142ca555f8992b8f8","after":"08e4d09ec2b8c3e515ce20a632be98f67a8fca39","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T21:35:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"044bbde66746a5b50c4f2902ce7ac0305db50494","after":"383d1e393b65a51f6d1a8b279a17e38527485e82","ref":"refs/heads/main","pushedAt":"2024-06-11T20:26:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation of join that rely on generated columns\nscan the left side of the join and search the rows on the right side\nby scanning all rows in the right side O(n*m). This is not optimal.\n\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join operation to O(n).\n\nWe taken into consideration that the right side might have duplicated\nrows and we build a list of rows for each key in the hash table.\n\nRelease-Note-Core: Implemented Hash Join capability for Join's using\n generated columns, resulting in drastically increase of performance\n for those join operations.\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9\nReviewed-on: https://gerrit.readyset.name/c/readyset/+/7582\nTested-by: Buildkite CI\nReviewed-by: Vassili Zarouba \nReviewed-by: Michael Zink ","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":"95369a9549b5cb2e9cfeb24572b75f4d436c3bf5","after":"e22172958a8741188a353a90e7a02e95e37fe6cc","ref":"refs/heads/Ia217ccb2758441969af5b38899feccb39b3d60e9","pushedAt":"2024-06-11T19:54:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation of join that rely on generated columns\nscan the left side of the join and search the rows on the right side\nby scanning all rows in the right side O(n*m). This is not optimal.\n\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join operation to O(n).\n\nWe taken into consideration that the right side might have duplicated\nrows and we build a list of rows for each key in the hash table.\n\nRelease-Note-Core: Implemented Hash Join capability for Join's using\n generated columns, resulting in drastically increase of performance\n for those join operations.\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":"806a2974ac5039f5e0642232ee2e5d3f335f1a1a","after":"95369a9549b5cb2e9cfeb24572b75f4d436c3bf5","ref":"refs/heads/Ia217ccb2758441969af5b38899feccb39b3d60e9","pushedAt":"2024-06-11T19:31:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation of join that rely on generated columns\nscan the left side of the join and search the rows on the right side\nby scanning all rows in the right side O(n*m). This is not optimal.\n\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join operation to O(n).\n\nWe taken into consideration that the right side might have duplicated\nrows and we build a list of rows for each key in the hash table.\n\nRelease-Note-Core: Implemented Hash Join capability increasing the\n performance of join operations.\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":"319a8f742c82ae014ccdb15fd9f50c452dbc5d6c","after":"587f4bd3ae5deb45f3d5a7b07f5ca222e296fb8d","ref":"refs/heads/I7c09688821e412c7ddd475e9bc4d2238ca56bff8","pushedAt":"2024-06-11T18:36:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"replicators: Add DDL vertical tests for MySQL\n\nThis commit adds DDL vertical tests for MySQL. The tests are a copy\nof the PostgreSQL tests, with the necessary changes to make them work\nand remove the unnecessary build of custom ENUM types which are not\nsupported to MySQL.\n\nThis is the initial version that will be used to replay failures.\n\nChange-Id: I7c09688821e412c7ddd475e9bc4d2238ca56bff8","shortMessageHtmlLink":"replicators: Add DDL vertical tests for MySQL"}},{"before":"d4ac99588b23c80581d3530baecdcff49817ddec","after":"319a8f742c82ae014ccdb15fd9f50c452dbc5d6c","ref":"refs/heads/I7c09688821e412c7ddd475e9bc4d2238ca56bff8","pushedAt":"2024-06-11T17:48:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"replicators: Add DDL vertical tests for MySQL\n\nThis commit adds DDL vertical tests for MySQL. The tests are a copy\nof the PostgreSQL tests, with the necessary changes to make them work\nand remove the unnecessary build of custom ENUM types which are not\nsupported to MySQL.\n\nThis is the initial version that will be used to replay failures.\n\nChange-Id: I7c09688821e412c7ddd475e9bc4d2238ca56bff8","shortMessageHtmlLink":"replicators: Add DDL vertical tests for MySQL"}},{"before":null,"after":"d4ac99588b23c80581d3530baecdcff49817ddec","ref":"refs/heads/I7c09688821e412c7ddd475e9bc4d2238ca56bff8","pushedAt":"2024-06-11T17:24:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"replicators: Add DDL vertical tests for MySQL\n\nThis commit adds DDL vertical tests for MySQL. The tests are a copy\nof the PostgreSQL tests, with the necessary changes to make them work\nand remove the unnecessary build of custom ENUM types which are not\nsupported to MySQL.\n\nChange-Id: I7c09688821e412c7ddd475e9bc4d2238ca56bff8","shortMessageHtmlLink":"replicators: Add DDL vertical tests for MySQL"}},{"before":"d23319c3cecb12c6ae2f239c8fff015beb250eaf","after":"806a2974ac5039f5e0642232ee2e5d3f335f1a1a","ref":"refs/heads/Ia217ccb2758441969af5b38899feccb39b3d60e9","pushedAt":"2024-06-11T16:38:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation scans the left side of the join and search the\nrows on the right side by scanning all rows in the right side O(n*m). This is\nnot optimal.\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join operation to O(n).\n\nRelease-Note-Core: Implemented Hash Join capability increasing the\n performance of join operations.\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":"6d3517e108bb4f58069a6d4462d9f591c2710ff2","after":"f8c4508afe59248352af8cf142ca555f8992b8f8","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T16:11:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhat caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"3a01b87a18c9c4d89723deed6cd586fe72c4e287","after":"6d3517e108bb4f58069a6d4462d9f591c2710ff2","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T16:10:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (column vs column)\nwe always figure out some common datatype, the operands might be coerced to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numerical types were wrongly defaulted to type DOUBLE,\nwhich caused issues later on. The fix added support for the missing\ndatatypes combinations. Note, the fix still does not handle\nDECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"103555bc43b039657bd00a456c9a1d4faa07cfb4","after":"3a01b87a18c9c4d89723deed6cd586fe72c4e287","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T16:08:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (like column vs column)\nwe always figure out some common datatype, the operands might be coersed to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numrical types were wrongly defaulted to type DOUBLE,\nwhich caused issues later on. The fix added support for the missing\ndatatypes combinations.\nNote, the fix still does not handle DECIMAL vs DECIMAL correctly.\n\nFixes: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"3b3d253732b6aa504df8aef0906d4106ab16a311","after":"103555bc43b039657bd00a456c9a1d4faa07cfb4","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T16:02:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\n- Currently, for any non parametrized binary operations (like column vs column)\nwe always figure out some common datatype, the operands might be coersed to.\nPrior to the fix, the temporal datatypes, CHAR/VARCHAR, BOOL, and certain\ncombinations of the numrical types were wrongly defaulted to type DOUBLE,\nwhich caused issues later on. The fix added support for the missing\ndatatypes combinations.\nNote, the fix still does not handle DECIMAL vs DECIMAL correctly.\n\nFix: REA-4440\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"dd6c8b3f49d7d7ff20cf23479436c3724db063a9","after":"044bbde66746a5b50c4f2902ce7ac0305db50494","ref":"refs/heads/main","pushedAt":"2024-06-11T15:55:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"controller: Reject unsupported MySQL storage engines\n\nSome storage engines are unsupported only because we require consistent\nsnapshots when first replicating a table, and not every storage engine\nhas the MVCC we currently rely on for that consistency. In the future,\nwe could remove this exception by wrapping our snapshots with table\nlocks for non-transactional storage engines. This could be a bad user\nexperience if someone is connecting Readyset to a live cluster causing\nit to, perhaps unwittingly, snapshot a large legacy MyISAM table and\npossibly lock up part of their workload. We could add an option to allow\nlocking tables and default to rejection. Either way, supporting locking\nwould add some complexity to the snapshot code that does not seem\nworthwhile absent explicit demand for this functionality. We already\nlock tables to read their binlog position, but we would then have to\nconditionally move the unlock to after the snapshot finishes. I believe\nthis would require making the `TableDumper` (or the `Future` that runs\nit) conditionally take ownership over the connection that locked the\ntable, but only if we have the locking option enabled and are\nsnapshotting a table that requires it.\n\nArguably, this decision should be up to the replicator, not the\ncontroller: as long as it can snapshot and forward rows for the table,\nthe server doesn't care how the table is persisted (or not), so we\nshould let the code in charge of replicating decide whether it can\nreplicate. However, the controller (and specifically `SqlIncorporator`)\nis already where we parse, inspect, and make decisions about DDL; this\ncodepath is common to both initial snapshotting and coming across DDL\nduring replication; and saying \"unsupported\" here already does what we\nwant with regard to adding the table to the `TableFilter`. It does not\nseem worth duplicating the parsing and discrimination in two places in\nthe replicator.\n\nFixes: REA-4328\nChange-Id: I8fcc95af5057f534841c669b46e47bd774ceed58\nReviewed-on: https://gerrit.readyset.name/c/readyset/+/7498\nTested-by: Buildkite CI\nReviewed-by: Marcelo Altmann ","shortMessageHtmlLink":"controller: Reject unsupported MySQL storage engines"}},{"before":null,"after":"3b3d253732b6aa504df8aef0906d4106ab16a311","ref":"refs/heads/I1474a36536d9a70f01c2c3089095fa9848ef2437","pushedAt":"2024-06-11T15:52:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow-expression: Add missing datatypes for MySQL data types conversion\n\nChange-Id: I1474a36536d9a70f01c2c3089095fa9848ef2437","shortMessageHtmlLink":"dataflow-expression: Add missing datatypes for MySQL data types conve…"}},{"before":"d4a642477c22629f0a514bebfac7b9dec38af348","after":"d23319c3cecb12c6ae2f239c8fff015beb250eaf","ref":"refs/heads/Ia217ccb2758441969af5b38899feccb39b3d60e9","pushedAt":"2024-06-11T15:17:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation scans the left side of the join and search the\nrows on the right side by scanning all rows in the right side O(n*m). This is\nnot optimal.\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join opearation to O(n).\n\nRelease-Note-Core: Implemented Hash Join capability increasing the\n performance of join operations.\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":null,"after":"d4a642477c22629f0a514bebfac7b9dec38af348","ref":"refs/heads/Ia217ccb2758441969af5b38899feccb39b3d60e9","pushedAt":"2024-06-11T15:15:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"readyset-dataflow: Add hash join to generated joins\n\nThe current implementation scans the left side of the join and search the\nrows on the right side by scanning all rows in the right side O(n*m). This is\nnot optimal.\nThis commit adds a hash join implementation to the generated joins.\nWe build a hash table with the rows of the right side and then scan the\nleft side and search the rows on the right side in the hash table which\nis an O(1) operation bringing the join opearation to O(n).\n\nChange-Id: Ia217ccb2758441969af5b38899feccb39b3d60e9","shortMessageHtmlLink":"readyset-dataflow: Add hash join to generated joins"}},{"before":"8f734bc0363f4c480495bb5473fabde25294989e","after":"dd6c8b3f49d7d7ff20cf23479436c3724db063a9","ref":"refs/heads/I2e7532b038f0be0e05347bd3f2f861d996221a25","pushedAt":"2024-06-07T13:52:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"dataflow: Correct return type for SUM in Postgres\n\nWe were returning what MySQL was expecting, so this is just doing what\nPostgres expects when appropriate.\n\nThis patch makes `readyset_dataflow` aware of `Dialect` in a way it\nwasn't before, which although limited to this operator constructor may\nbe undesirable; but the alternative of having a secondary function for\ndetermining the type which `mir_to_flow` would have to call separately\nwas equally if not more unwieldy.\n\nAddresses: REA-4283\nChange-Id: I2e7532b038f0be0e05347bd3f2f861d996221a25\nReviewed-on: https://gerrit.readyset.name/c/readyset/+/7535\nTested-by: Buildkite CI\nReviewed-by: Jason Brown ","shortMessageHtmlLink":"dataflow: Correct return type for SUM in Postgres"}},{"before":null,"after":"4b49a9f7f1035b08d7a9ef398715d225eeb1ef34","ref":"refs/heads/Ib56c313843796776d8bb5697843aaffbb1ebe633","pushedAt":"2024-06-07T13:39:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"readysetbot","name":null,"path":"/readysetbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/75456260?s=80&v=4"},"commit":{"message":"quickstart: Check DB size\n\nAdd a script to check the size of the database on MySQL and PostgreSQL.\nThis script also get the count of tables present in the database.\n\nChange-Id: Ib56c313843796776d8bb5697843aaffbb1ebe633","shortMessageHtmlLink":"quickstart: Check DB size"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEY7HcrQA","startCursor":null,"endCursor":null}},"title":"Activity · readysettech/readyset"}