Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: refactor how we pass resolver instance to serializers #11280

Open
humitos opened this issue Apr 16, 2024 · 0 comments
Open

API: refactor how we pass resolver instance to serializers #11280

humitos opened this issue Apr 16, 2024 · 0 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Apr 16, 2024

Consider using the serializer's context instead of parent to share the Resolver instance.

This was suggested in #11205 (comment) by @stsewd.

Also, note that this may not be needed if we find a way to share this Resolver instance all over the request, as mentioned in #10456
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Apr 16, 2024
@humitos humitos mentioned this issue Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humitos