Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification: beta swap template logic fixes #11209

Open
agjohnson opened this issue Mar 12, 2024 · 0 comments
Open

Notification: beta swap template logic fixes #11209

agjohnson opened this issue Mar 12, 2024 · 0 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Mar 12, 2024

While working on #11208 I found issues likely affecting the beta notification message. Just noting for now:

  • When on the beta dashboard, {{ PRODUCTION_DOMAIN }} is beta.readthedocs.org, not readthedocs.org. The link should use PRODUCTION_DOMAIN|slice:"5:" or similar
  • It's not possible to link to the commercial dashboard beta with simply beta.readthedocs.com/projects/foo, as this will always 404 if the user is not logged in. Instead Add build detail view beta notification #11208 links to the login view first, to ensure the user is always seeing the login first if they are not logged in yet.
  • The header can be conditional too, and "You are using our new beta dashboard" on the beta instance.

This notification is getting into some complex area already, it might be also worth implementing the last part that #11208 added, which was linking to the same url between both dashboards.

@agjohnson agjohnson added the Bug A bug label Mar 12, 2024
@agjohnson agjohnson added the Accepted Accepted issue on our roadmap label Mar 12, 2024
@agjohnson agjohnson added the Improvement Minor improvement to code label Mar 12, 2024
@agjohnson agjohnson self-assigned this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug Improvement Minor improvement to code
Projects
Status: Planned
Development

No branches or pull requests

1 participant