-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding specific libuv adapter #74
Labels
Comments
Note that I've fixed the building on windows for php-uv. |
Open
See also @CharlotteDunois's excellent version here: https://github.com/AndromedaGalaxy/reactphp-libuv-process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We may want to add a specific adapter taking advantage of libuv's process handling logic:
To be clear, this project works just fine with all loop implementations, including the default
StreamSelectLoop
andExtUvLoop
. This potential adapter could take advantage of some of the optimizations inside libuv and avoid some of the known limitations of the project.In particular, this may help with Windows support (#9) in the future because libuv supports pipes with overlapped mode on Windows. Note that a Windows build of
ext-uv
does not appear to be available at the time of writing this, but it is believed to change again in the future (amphp/ext-uv#63).The text was updated successfully, but these errors were encountered: