-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate flaky FluxRefCountGraceTest > raceSubscribeAndCancelNoTimeout
raceTest
#3639
Comments
Interestingly, the combination of For reference, the output when the test fails:
It feels like at some racy case both Subscribers of FluxRefCountGrace get the same error drop caused by cancellation. What is unexpected though is that both trigger FluxReplay.connect, while the assumption is that only one subscriber makes that call. |
For debugging locally, I added
to
|
I just wanted to chip in. When I was doing my changes to the replay-buffer I found that there was a small detail in there that, when not implemented properly in the ReplayBuffer, these tests (this and similar ones across the project) would fail. |
Thanks @MikkelHJuul – please have a look at the linked PR (#3707), I suppose it incorporates the same cancellation validation, although using |
@chemicL - I'm not that deeply invested in to this part of these interactions but it looks and sounds reasonable |
The text was updated successfully, but these errors were encountered: