Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent root from being recreated on react 18 (recreation of #1305) #1335

Merged
merged 1 commit into from
May 16, 2024
Merged

Prevent root from being recreated on react 18 (recreation of #1305) #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# react-rails

If you need help upgrading `react-rails`, `webpacker` to `shakapacker`, or JS packages, contact [email protected]. The ShakaCode.com team is helping to maintain this Ruby gem. You also might want to consider the [react_on_rails](https://github.com/shakacode/react_on_rails) gem.
If you need help upgrading `react-rails`, `webpacker` to `shakapacker`, or JS packages, contact [email protected]. The ShakaCode.com team is helping to maintain this Ruby gem. You also might want to consider the [react_on_rails](https://github.com/shakacode/react_on_rails) gem.

[#1209 2.7 Release Discussion](https://github.com/reactjs/react-rails/issues/1209)

Expand All @@ -12,6 +12,8 @@ _Please add entries here for your pull requests that are not yet released. Inclu
#### Fixed
- Replaced call to ReactRailsUJS.unmountComponents that was erroneously removed by #1290 in 3.0.0 #1339

- Prevent roots from being re-created when using React 18 [PR 1305](https://github.com/reactjs/react-rails/pull/1305) by [diogobeda](https://github.com/diogobeda)

## [3.2.0] - 2024-01-10

#### Changed
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ GEM
thor (1.2.1)
tilt (2.1.0)
timeout (0.4.1)
turbo-rails (2.0.5)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
websocket (1.2.9)
Expand Down Expand Up @@ -270,6 +274,7 @@ DEPENDENCIES
react-rails!
selenium-webdriver
test-unit (~> 2.5)
turbo-rails

BUNDLED WITH
2.4.9
5 changes: 5 additions & 0 deletions gemfiles/shakapacker.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@ GEM
thor (1.2.2)
tilt (2.2.0)
timeout (0.4.1)
turbo-rails (2.0.5)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
websocket (1.2.10)
Expand Down Expand Up @@ -280,6 +284,7 @@ DEPENDENCIES
selenium-webdriver
shakapacker (= 7.2.0)
test-unit (~> 2.5)
turbo-rails

BUNDLED WITH
2.4.9
5 changes: 5 additions & 0 deletions gemfiles/sprockets_3.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ GEM
thor (1.2.1)
tilt (2.0.10)
timeout (0.4.1)
turbo-rails (2.0.5)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
turbolinks (5.2.1)
turbolinks-source (~> 5.2)
turbolinks-source (5.2.0)
Expand Down Expand Up @@ -284,6 +288,7 @@ DEPENDENCIES
sprockets (~> 3.5)
sprockets-rails
test-unit (~> 2.5)
turbo-rails
turbolinks (~> 5)

BUNDLED WITH
Expand Down
5 changes: 5 additions & 0 deletions gemfiles/sprockets_4.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ GEM
thor (1.2.1)
tilt (2.0.10)
timeout (0.4.1)
turbo-rails (2.0.5)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
turbolinks (5.2.1)
turbolinks-source (~> 5.2)
turbolinks-source (5.2.0)
Expand Down Expand Up @@ -284,6 +288,7 @@ DEPENDENCIES
sprockets (~> 4.0.x)
sprockets-rails
test-unit (~> 2.5)
turbo-rails
turbolinks (~> 5)

BUNDLED WITH
Expand Down
2 changes: 1 addition & 1 deletion lib/assets/javascripts/react_ujs.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions react-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'pry-byebug'
s.add_development_dependency 'package_json'
s.add_development_dependency 'rails', '~> 7.0.7', '>= 7.0.7.2'
s.add_development_dependency 'turbo-rails'
s.add_development_dependency 'minitest-retry'

s.add_dependency 'connection_pool'
Expand Down
Loading
Loading