Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timer percentiles get stuck if update isn't called #215

Open
newhook opened this issue Sep 9, 2017 · 1 comment · May be fixed by #254
Open

timer percentiles get stuck if update isn't called #215

newhook opened this issue Sep 9, 2017 · 1 comment · May be fixed by #254

Comments

@newhook
Copy link

newhook commented Sep 9, 2017 •
edited
Loading

I'm using a timer to record request latency percentiles. The problem is if there are no requests (meaning no calls to Update) the percentiles get "stuck" (meaning they latch on the last set of percentiles). Looking at the code this is because ExpDecaySample.update is the only thing that updates the samples (there is nothing that "ticks" the samples).

Is this deliberate?

I believe the java impl doesn't have this issue because the dataset is rescaled when fetched.

https://github.com/dropwizard/metrics/blob/4.0-development/metrics-core/src/main/java/com/codahale/metrics/ExponentiallyDecayingReservoir.java
@ashrayjain
Copy link

@mihasya

Are there any plans/interest for addressing this? Happy to contribute a PR if so

@ashrayjain ashrayjain linked a pull request Jan 19, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rescale samples on reads too ashrayjain/go-metrics
2 participants
@ashrayjain @newhook