Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for adding Neovim-LanguageClient configuration #234

Open
drzln opened this issue Mar 5, 2019 · 7 comments
Open

PR for adding Neovim-LanguageClient configuration #234

drzln opened this issue Mar 5, 2019 · 7 comments

Comments

@drzln
Copy link

drzln commented Mar 5, 2019

Hello,

I have a PR for adding a configuration for https://github.com/autozimu/LanguageClient-neovim to the documentation how should I go about doing this?

@rcjsuen
Copy link
Owner

rcjsuen commented Mar 6, 2019

@luisfelipemourapereira Thank you for your interest in contributing to our documentation.

Let me think about how I want this structured and then I’ll get back to you.

@rcjsuen
Copy link
Owner

rcjsuen commented Mar 18, 2019

@luisfelipemourapereira Could you add a new ### Neovim section under ## Installation Instructions in README.md?

  1. Include Fix #234 in the header of your Git commit message.
  2. Commit with -s so that it includes a Signed-off-by footer in your Git commit message.

Thank you for your help and I appreciate your patience regarding my late reply.

@drzln
Copy link
Author

drzln commented Mar 18, 2019 via email

@rickywu
Copy link

rickywu commented Jul 2, 2019

Any update? I want to config work with LanguageClient-neovim

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 2, 2019

@rickywu For starters, have you installed npm on your machine?

@rickywu
Copy link

rickywu commented Jul 2, 2019

@rcjsuen I tried and works well now:
npm install -g dockerfile-language-server-nodejs

add this in config file:
\ 'dockerfile': ['docker-langserver', '--stdio'],

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 2, 2019

@rickywu Thank you for sharing your solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants