Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Any plan for Plasma 6? #123

Open
crazyraven opened this issue Mar 7, 2024 · 26 comments
Open

[Feature request] Any plan for Plasma 6? #123

crazyraven opened this issue Mar 7, 2024 · 26 comments

Comments

@crazyraven
Copy link

Hello,

Kde Plamsa 6 will be landed most major distro soon and I've already upgraded to Plasma 6.
Do you have any plan panon support for Plasma 6? or any workarounds?

Thank you

Best regards,

@crazyraven crazyraven changed the title [Feature request] Any paln for Plasma 6? [Feature request] Any plan for Plasma 6? Mar 7, 2024
@zcbxxx1
Copy link

zcbxxx1 commented Mar 8, 2024

+1

1 similar comment
@twoexem
Copy link

twoexem commented Mar 8, 2024

+1

@dtr125
Copy link

dtr125 commented Mar 8, 2024

I really hope this can be updated, i only started using this widget recently as it looks really cool, and Arcolinux started using Plasma-6 recently.

I think this page says how to convert it to work on Plasma-6 if anyone is knowledgeable enough: https://develop.kde.org/docs/plasma/widget/porting_kf6/?ref=news.itsfoss.com

@ghhccghk
Copy link

I'm trying to port and find that there are a lot of problems that can be started, but can't solve the inability to set the configuration. I may not handle these issues well

@MizurenNanako
Copy link

+1

@oberkut
Copy link

oberkut commented Mar 16, 2024

Please update to QT6

@f35f0ef9d0e827dae86552d3899f78fc

2021 is last activity in the repo. Is anyone with Maintainer status still around? If not, we might need someone to start a whole new repo and uplift this project to work with Plasma 6.

@Megalomaniak
Copy link

Haven't tried it yet but fork w/ porting effort towards Plasma 6: https://github.com/qspidy/panon

@zcbxxx1
Copy link

zcbxxx1 commented Mar 25, 2024

Haven't tried it yet but fork w/ porting effort towards Plasma 6: https://github.com/qspidy/panon

Great!
Now, can we do sonething test in plasma6 on my PC?

@Megalomaniak
Copy link

Megalomaniak commented Mar 25, 2024

@zcbxxx1 You can try the build instructions just remember for the first line(repo cloning step) to type the forks repo URL and not just copy paste the instructed line as-is since the readme is unchanged and so you'd end up building this upstream repo instead of the fork.

NB. I haven't vetted that this is a safe repo. You build and use this at your own discretion.

edit: author does seem a bit sus based on their blog. Clear interest in infosec and black-hattery.

edit 2: at a quick glance the only .js file changed from this repo seemed fine. But again, only a quick glance through the repo. Might be trying to fetch your username tho and the repo might change over time. Always make sure to read changes in forks for yourself if security conscious.

@qspidy
Copy link

qspidy commented Mar 25, 2024

Well, I've never imagined that my fork would gain attention. 👀 🤣 To prevent further misunderstandings, I'll explain my work on the fork.

  • According to KDE doc Porting Plasmoids to KF6, I did some modifications on code, but it's not enough.
  • Since Plasma 6 is built on top of Qt 6 and fragmentShader (property of ShaderEffect) don't support GLSL (OpenGL Shading Language) source code any more, qsb file is needed to make the ShaderEffect work.
  • I modified the function get_root() in utils.js to directly return the root dir of panon since plasmoid.file doesn't work on plasma6 (I got utils.js:2: TypeError: Cannot call method 'file' of null when testing).

It's been weeks I left this behind, but I'm keeping up with this issue, now the last problem is how to make the shaders work, I'm still working on it but I haven't found any plasmoid example based on qsb files, so I'm not sure if it works simply generating the qsb from old shaders.

I've pushed my latest commit to my fork, feel free to review. 😆

@Megalomaniak is right, you should never try running uncensored code on your computer unless you know what you are doing. 👍

@Megalomaniak
Copy link

Megalomaniak commented Mar 25, 2024

Probably a mistranslation but uncensored code is likely what you would want, as in, it's reviewable(I take censored to mean obfuscated in some manner). I presume unreviewed or unverified code was meant by it.

As for the TypeError, sounds like the file method in the plasmoid class has likely been changed in some way, possibly even renamed perhaps. But I'm not a KDE/Qt developer so consulting with developer documentation is likely the way to go.

Actually scratch that, it says that it can't call method 'file' of Null meaning for some reason it can't call plasmoid class. Instead gets Null. Was plasmoid renamed perhaps? Might they have started capitalizing class names for an example? Could it be as simple as it needs to be Plasmoid instead of plasmoid?

edit: ok quick look through the docs, there's some heavy refactoring needed. All the Kirigami stuff and everything else. Big oof.

@zcbxxx1
Copy link

zcbxxx1 commented Mar 30, 2024

Well, I've never imagined that my fork would gain attention. 👀 🤣 To prevent further misunderstandings, I'll explain my work on the fork.

* According to KDE doc [Porting Plasmoids to KF6](https://develop.kde.org/docs/plasma/widget/porting_kf6/), I did some modifications on code, but it's not enough.

* Since Plasma 6 is built on top of Qt 6 and fragmentShader (property of ShaderEffect) don't support GLSL (OpenGL Shading Language) source code any more, [qsb file is needed to make the ShaderEffect work](https://doc.qt.io/qt-6/qml-qtquick-shadereffect.html#shaders).

* I modified the function get_root() in utils.js to directly return the root dir of panon since `plasmoid.file` doesn't work on plasma6 (I got `utils.js:2: TypeError: Cannot call method 'file' of null` when testing).

It's been weeks I left this behind, but I'm keeping up with this issue, now the last problem is how to make the shaders work, I'm still working on it but I haven't found any plasmoid example based on qsb files, so I'm not sure if it works simply generating the qsb from old shaders.

I've pushed my latest commit to my fork, feel free to review. 😆

@Megalomaniak is right, you should never try running uncensored code on your computer unless you know what you are doing. 👍

I seem to have found some problems on my computer when trying to install panon on kde6, but I'm not sure if it's my personal fault. Can you open the issues in your fork to facilitate everyone's discussion and solution?

@qspidy
Copy link

qspidy commented Mar 30, 2024

For that case, I created a room on matrix.org, welcome to join and discuss, any suggestions or help would be appreciated:

https://matrix.to/#/#panon:matrix.org

@lunelovehearn
Copy link

For that case, I created a room on matrix.org, welcome to join and discuss, any suggestions or help would be appreciated:

https://matrix.to/#/#panon:matrix.org

just checked your fork, but idk how to test install panon on plasma 6.

@dtr125
Copy link

dtr125 commented Aug 13, 2024

I still hope that one day someone is able to get this working for Plasma-6. :-/, since this was one of the few good audio visualizers we had on Plasma-5. As the implementation of QT6 seems to be what broke the shaders in it, hopefully one of their Devs may one day step-up and help fix it since they probably understand what would need to be adjusted to complete the code changes.

@flafflar
Copy link

I finally got it working!!!

See my fork here: https://github.com/flafflar/panon

@Doridian
Copy link

@flafflar Do I need to do anything special? I got it installed but I'm only getting a blank panel. Settings are all greyed out until I switch to the "About" section and then back. The settings seem to save successfully as well, but nothing renders at all.
This is my first time not just "using" a Plasma extension, so I'm not sure what the best steps for debugging this would be? Is there any logfiles or something? journalctl --user doesn't seem to have anything useful (at least to my eyes). A bunch of warnings complaining about settings/config related things (as in, the settings UI), but nothing about the panel from what I can see

@flafflar
Copy link

@flafflar Do I need to do anything special? I got it installed but I'm only getting a blank panel. Settings are all greyed out until I switch to the "About" section and then back. The settings seem to save successfully as well, but nothing renders at all.

Check if the qsb binary exists in your system. It should be in /usr/lib/qt6/bin.

This is my first time not just "using" Plasma extension, so I'm not sure what the best steps for debugging this would be? Is there any logfiles or something? journalctl --user doesn't seem to have anything useful (at least to my eyes). A bunch of warnings complaining about settings/config related things (as in, the settings UI), but nothing about the panel from what I can see

You can run it using plasmoidviewer --applet, which will provide some useful debugging output.

Please post any issues you find with the fork in my own repo, not here. I will try to fix them as soon as I can.

@Doridian
Copy link

Doridian commented Aug 19, 2024

Please post any issues you find with the fork in my own repo, not here. I will try to fix them as soon as I can.

Oh, apologies, I forgot the reason I posted here entirely: Your repo has issues turned off (default for forks), otherwise I would've opened an issue there. Sorry for not pointing that out.

I have the qsb binary.

@dtr125
Copy link

dtr125 commented Aug 20, 2024

I finally got it working!!!

See my fork here: https://github.com/flafflar/panon

Thank you so much for solving this Plasma-6 port!
(I'd only started using Panon just before Plasma-6 dropped on Arch and was gutted when it stopped working, so you've made my day :-) )

@crazyraven
Copy link
Author

I finally got it working!!!

See my fork here: https://github.com/flafflar/panon

It works flawlessly with your AUR build. THANK YOU for making plasma 6 great again!!

@Phen-Ro
Copy link

Phen-Ro commented Nov 11, 2024

@flafflar Thank you! Would you mind making an PR to this repo to make your fork easier to find for passers by?

@liangjihua
Copy link

I finally got it working!!!

See my fork here: https://github.com/flafflar/panon

Great Job! Thank you!

@SimonTelescopium
Copy link

Thank you - you are awesome :-)

@flafflar
Copy link

Thank you all for the positive comments! :)

@flafflar Thank you! Would you mind making an PR to this repo to make your fork easier to find for passers by?

Sure, but I don't think it will ever be merged. The owner of this repo is completely inactive, I have even tried to contact them personally and they gave no signs of life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests