How to launch Player in window mode?

[crystaldev3d]

Hi, devs! Is there way to runing player in window mode?
I'm currently use this setting in VSCode to launch Player with sample-project-master.

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "(Windows) Launch",
            "type": "cppvsdbg",
            "request": "launch",
            "program": "${workspaceFolder}\\build\\bin\\Debug\\Player.exe",
            "args": [   "--pp", "${workspaceFolder}\\Project", 
                        "--plugins", "SampleProject",
                        "--main","SampleProject"],
            "stopAtEntry": false,
            "cwd": "${workspaceFolder}\\build\\bin\\Debug",
            "environment": [],
            "console": "externalTerminal",
            //"preLaunchTask": "Build Debug"
        }
    ]
}

[eugeneko]

I assume you use up-to-date repos?
Then your issue may be related to the recent update in config handling.

Engine parameters are loaded from here now:
https://github.com/rbfx/sample-project/blob/master/Project/Data/EngineParameters.json

Pros: you don't have to specify plugins on launch anymore
Cons: you have to remove "Borderless" from json in order to run sample windowed.

Maybe I should have never added "Borderless" in EngineParameters.json in first place. I will think and maybe remove it from there.

[crystaldev3d]

I've just tested 'EngineParameters.json' and it looks like the settings file is not working(
my bat file

Player.exe --pp .\Project
pause

log says...

[17:16:59] [debug] [main] : Created directory C:/Users/user/AppData/Roaming/Urho3D Rebel Fork/Unspecified Application/
[17:16:59] [error] [main] : Failed to load object from JSON: 'ConfigFile/Default/element/Variables/element/value' has unexpected type
[17:16:59] [error] [main] : Failed to parse settings file 'EngineParameters.json'
[17:16:59] [info] [main] : ConfigFile overrides 'conf://EngineParameters.json' are loaded
[17:16:59] [debug] [main] : Initialising SDL
[17:16:59] [info] [main] : Loaded static plugin 'Builtin.SceneViewer'
[17:16:59] [info] [main] : Created 5 worker threads
[17:16:59] [info] [main] : Added resource path C:/Projects/RBFX/sample-project-master2/Project/Data/
[17:16:59] [info] [main] : Added resource path C:/Projects/RBFX/sample-project-master2/Project/CoreData/
[17:16:59] [info] [main] : Adapter used NVIDIA GeForce GTX 1080
[17:16:59] [info] [main] : Set screen mode 2560x1440 rate 60 Hz fullscreen monitor 0
[17:16:59] [info] [main] : Initialized input
[17:16:59] [debug] [main] : Loading resource Techniques/NoTexture.xml
[17:16:59] [debug] [main] : Loading resource Textures/Ramp.png
[17:16:59] [debug] [main] : Loading temporary resource Textures/Ramp.xml
[17:16:59] [debug] [main] : Loading resource Textures/Spot.png
[17:16:59] [debug] [main] : Loading temporary resource Textures/Spot.xml
[17:16:59] [debug] [main] : Loading resource RenderPaths/Forward.xml
[17:16:59] [info] [main] : Initialized renderer
[17:17:00] [info] [main] : Set audio mode 48000 Hz 5.1 Surround interpolated
[17:17:00] [info] [main] : Initialized engine
[17:17:00] [info] [main] : Loaded font face 'Anonymous Pro' [regular] from 'Fonts/Anonymous Pro.ttf'.
[17:17:00] [info] [main] : Set audio mode 48000 Hz 5.1 Surround interpolated
[17:17:00] [info] [main] : Set audio mode 48000 Hz 5.1 Surround interpolated
[17:17:00] [info] [main] : Set audio mode 48000 Hz 5.1 Surround interpolated
[17:17:00] [info] [main] : Set audio mode 48000 Hz 5.1 Surround interpolated
[17:17:00] [debug] [main] : Reloading shaders
[17:17:00] [info] [main] : Application is started with 0 plugins
[17:17:06] [info] [main] : Application is stopped with 0 plugins
[17:17:06] [debug] [main] : Quitting SDL

[eugeneko]

Failed to load object from JSON: 'ConfigFile/Default/element/Variables/element/value' has unexpected type

That's very weird. Does it happen on sample-project "as is", with up-to-date player? Can you show EngineParameters.json?
By the way, I removed Borderless setting from sample project.

[crystaldev3d]

Now I figured out what the problem was.
Yes, at first the configuration file was a bit broken, with the original configuration file there are no parsing errors.
The thing is that after first launch Player.exe creates a copy or version with default settings of configuration file here (C:\Users\user\AppData\Roaming\Urho3D Rebel Fork\Unspecified Application\EngineParameters.json) and then Player.exe doesn't care about settings which are set or changed in original one. I have to manually delete (C:\Users\user\AppData\Roaming\Urho3D Rebel Fork\Unspecified Application\EngineParameters.json) and then Player.exe starts to accept new settings again.
my EngineParameters.json

{
    "Default": [
        {
            "Flavor": [
                {
                    "key": "*",
                    "value": ["*"]
                }
            ],
            "Variables": [
                {
                    "key": "FullScreen",
                    "type": "Bool",
                    "value": false
                },
                {
                    "key": "WindowWidth",
                    "type": "Int",
                    "value": 1920
                },
                {
                    "key": "WindowHeight",
                    "type": "Int",
                    "value": 1080
                },
                {
                    "key": "Plugins",
                    "type": "String",
                    "value": "SampleProject"
                },
                {
                    "key": "MainPlugin",
                    "type": "String",
                    "value": "SampleProject"
                }
            ]
        }
    ]
}

[gleblebedev]

@eugeneko did you eliminate evaluating diff before saving the config during refactoring?

[eugeneko]

@gleblebedev nope?

and then Player.exe doesn't care about settings which are set or changed in original one.
@crystaldev3d ah, yes, it remembers some settings. FYI, you could have just Alt+Enter-ed to go windowed and Player would have remembered it.

[gleblebedev]

Would "-w" work?

[crystaldev3d]

I tried it but it doesn't seem to work

[eugeneko]

Yeah, it will not work due to our flag design, sadly. -w makes window non-fullscreen, but borderless is already not a fullscreen.