Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test linux://python/ray/tests:test_channel is consistently_failing #45264

Closed
can-anyscale opened this issue May 11, 2024 · 26 comments · Fixed by #45297
Closed

CI test linux://python/ray/tests:test_channel is consistently_failing #45264

can-anyscale opened this issue May 11, 2024 · 26 comments · Fixed by #45297
Assignees
@stephanie-wang
Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@can-anyscale
Copy link
Collaborator

CI test linux://python/ray/tests:test_channel is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/4400#018f6537-f627-42c9-a037-195010e2b35c
- https://buildkite.com/ray-project/postmerge/builds/4400#018f6537-f623-449e-a07b-e99c4a177a24

DataCaseName-linux://python/ray/tests:test_channel-END
Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels May 11, 2024
@can-anyscale
Copy link
Collaborator Author

This test is now considered as flaky because it has been failing on postmerge for too long. Flaky tests do not run on premerge.

@can-anyscale can-anyscale reopened this May 11, 2024
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4405#018f65c0-6f5b-4835-bac9-cb48f84f57c5

@can-anyscale can-anyscale reopened this May 11, 2024
@can-anyscale
Copy link
Collaborator Author

blame to 79f3995

@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_channel is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/4400#018f660e-9044-4b7e-a57e-a846a920ebc3
- https://buildkite.com/ray-project/postmerge/builds/4400#018f660e-7dde-4b7a-a1f2-3d33a3f94015
- https://buildkite.com/ray-project/postmerge/builds/4400#018f656f-0e1e-4003-9d65-2719ca03789b
- https://buildkite.com/ray-project/postmerge/builds/4400#018f6537-f627-42c9-a037-195010e2b35c
- https://buildkite.com/ray-project/postmerge/builds/4400#018f6537-f623-449e-a07b-e99c4a177a24

DataCaseName-linux://python/ray/tests:test_channel-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Blamed commit: 79f3995 found by bisect job https://buildkite.com/ray-project/release-tests-bisect/builds/1124

@can-anyscale
Copy link
Collaborator Author

This test is now considered as flaky because it has been failing on postmerge for too long. Flaky tests do not run on premerge.

@stephanie-wang stephanie-wang removed the weekly-release-blocker Issues that will be blocking Ray weekly releases label May 13, 2024
@stephanie-wang stephanie-wang mentioned this issue May 13, 2024
Merged
stephanie-wang added a commit that referenced this issue May 13, 2024
@stephanie-wang
[core][experimental] Fix broken channel test (#45297)
a563598 
Fixes test that was broken due a hidden merge conflict between #45092 and #45119.
Related issue number

Closes #45264.

Signed-off-by: Stephanie Wang <[email protected]>
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4483#018f7ec2-d240-404a-8aed-6d0fed99e914

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4487#018f7fd4-9b70-40e8-ac4d-2c4100608034

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4488#018f8231-e874-40bb-a254-ddd13ee4df8e

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4498#018f830c-a0a9-4f8e-8457-f5e714d641b4

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4504#018f83e9-d628-4e10-929c-9c3842e1022f

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4505#018f84f9-fa3f-47c7-9be4-6bc47ab27d99

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4509#018f8759-49ac-4cf3-98c3-614c6fad2db5

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4511#018f882d-496c-4197-bf67-94c8a7b3bb4a

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4517#018f890f-2fe3-462d-bd0d-a03a454b7d18

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4520#018f8a1b-ff01-4cb9-aff8-26e23a5c6f35

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4527#018f946e-2b2a-40e1-b2b6-0be36c8ebb2a

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4530#018f96cc-335e-431c-bdb6-4d7c08fc0052

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4538#018f97a7-2fdc-4bd8-9dc2-3c5b1b18ac1c

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4542#018f987e-a9e8-4414-ab08-3826a45a2577

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4546#018f998e-f178-45ea-9357-8840aca3daa7

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4551#018f9bec-2eb1-4bda-92ff-882f01b3fdae

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4556#018f9ccc-2c09-48c3-aabb-1d4ac6415968

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4561#018f9da7-d4f8-4c41-ad7f-7cbcd834c13b

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4564#018f9eba-4a44-4142-b9a5-4be5e1086871

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4564#018f9eeb-8d83-4c3b-b68a-b9ae0509479b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanie-wang stephanie-wang

Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core][experimental] Fix broken channel test stephanie-wang/ray
2 participants
@stephanie-wang @can-anyscale