-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check select! bug in async #49
Labels
bug
Something isn't working
Comments
Sorry for late response, I am in school now. |
Is this still an issue? |
This is mostly a prompt to check whether this is a bug at some point. I haven't looked into it more than superficially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suspect that this is still a bug as the select can complete on either branch of the select in a non-deterministic fashion. The right way to handle (I think) is to not fail when the sender fails to send. The send failing can indicator that the receiver is closed. See https://docs.rs/tokio/latest/tokio/sync/mpsc/struct.Sender.html
I think there's probably a second bug with this in how cancelations are handled https://docs.rs/tokio/latest/tokio/sync/mpsc/struct.Sender.html#cancel-safety
Originally posted by @joshka in #48 (review)
The text was updated successfully, but these errors were encountered: