Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CurveToLine and LineToCurve types #5

Open
terryspitz opened this issue Jul 23, 2020 · 0 comments
Open

Add CurveToLine and LineToCurve types #5

terryspitz opened this issue Jul 23, 2020 · 0 comments

Comments

@terryspitz
Copy link

README correctly indicates that Spiro's Left and Right constraints were confusing to use and removed them in this implementation.
In code I find this confusion is because they're named according to the order of the array which is easily confused with left and right as screen coordinates. I suggest calling them CurveToLine and LineToCurve and re-adding them to spline-research as they continue to be a useful way to weld lines to curves. The implementation is easy by translating them to a corner with an explicit tangent early in solve. This terminology may help in Spiro too.

To solve the confusion in a GUI, you may need to show this as a new type of explicit tangent.

(context: i'm translating this library to F# to here: https://github.com/terryspitz/dactyl-font/tree/spline-research/spline-research)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant