Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local-path-provisioner in helm dependency. #233

Closed
vincent-herlemont opened this issue Feb 22, 2022 · 2 comments
Closed

Add local-path-provisioner in helm dependency. #233

vincent-herlemont opened this issue Feb 22, 2022 · 2 comments
Labels

Comments

@vincent-herlemont
Copy link

vincent-herlemont commented Feb 22, 2022

Regarding the documentation Uninstall.

Before uninstallation, make sure the PVs created by the provisioner has already been deleted. Use kubectl get pv and make sure no PV with StorageClass local-path.

Following the documentation it's impossible to add local-path-provisioner in the same helm chart as an app because that conflicts with helm deletion order. And in some case, we don't want to delete data.

So, I have created a small proof of concept with a helm chart with local-path-provisioner as dependencies, you can try here:

  1. Requirement helm and k3d.
    > helm version --short
    v3.7.0+geeac838
    > k3d --version
    k3d version v5.3.0
  2. Downlowd/Uncompress the helm chart: test-lpp-in-helm-dependencies.zip (see Gist).
  3. Create the cluster k3d cluster create -c ./k3d-config.yaml
  4. Install the helm chart helm install test-lpp .
  5. Create a test file in the volume kubectl exec volume-test -- sh -c "echo local-path-test > /data/test"
  6. Re-install the helm chart helm uninstall test-lpp && sleep 30 && helm install test-lpp .
  7. Test if the volume is correctly re-mounted
    kubectl exec volume-test -- sh -c "cat /data/test"
    local-path-test

All seems to work as well.

So questions:

  • So, what is exactly the concern if local-path-provisioner is uninstalled before the PVs are deleted?
  • Is there a design troubleshooting to add local-path-provisioner in helm dependencies that I do not see?
Copy link

github-actions bot commented Jul 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jul 3, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant