Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framed camera follow doesn't follow the target vertically if it's inactive #395

Open
cathairnowhere opened this issue Oct 1, 2024 · 0 comments

Comments

@cathairnowhere
Copy link

Issue description

Hey there,
I appreciate there's a framed follow refactor in the works but I figured I'd throw another issue into the hat.

I have multiple pcams set up in a 2d scene with their inactive update mode set to always. I handle switching the active pcam by changing the priority of the previous and the target pcam when the character enters an Area2D associated with the cameras.

Two of the cameras are set to framed follow the player while one is simple following a vertically moving platform (synced with physics) and is active while the character is on the platform. The framed follow seems to work well enough at start, and while upon leaving the platform the camera correctly switches back to the previous camera, only the horizontal position is updated. Even if entering the previous camera zone/the general area where the camera seems to be, the camera remains misaligned both vertically and horizontally.

+1: wording of the built in dead_zone_height documentation/tooltip has a copypasta error (?) as it says that upon a vertical change the camera will follow the target horizontally

Steps to reproduce

  • Add 2 pcams, one framed follow with the player as target, one simple follow on the platform
  • Priority by default 0
  • Main camera's pirority changes to 10 if its area is entered
  • Special camera's priority is changed to 50 if its area entered, changes to 0 if left

(Optional) Minimal reproduction project

framed-minimal-repo.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant