Target tracking using global_position instead of position

[m4rr5]

In a project I am working on, I am integrating an external physics engine that uses a different axis orientation (Z+ up) from Godot itself (Y+ up). I deal with that by rotating my world in Godot by 90 degrees. This also means I need to treat the cameras a little differently but I've managed to make that all work except for one thing: target tracking.

After a bit of experimentation with the phantom-camera code it boils down to using get_global_position() instead of get_position() when retrieving the position of a tracked target. Of course this is a trivial change I could make myself (in a few places) but I am wondering if it would be possible to support my use case? For example by making this a parameter of PhantomCamera3D (use_global_position)?

[ramokz]

The usage of get_position() is actually a mistake that I just hadn't noticed... Should be fixed in the latest release where every instance is using get_global_position() instead.

Thanks for highlighting it!

[m4rr5]

You're welcome, thanks for sharing this great addon, it's extremely useful.

[m4rr5]

The usage of get_position() is actually a mistake that I just hadn't noticed... Should be fixed in the latest release where every instance is using get_global_position() instead.

Thanks for highlighting it!

It looks like there are a few places you forgot in phantom_camera_3D.gd:

• phantom-camera/addons/phantom_camera/scripts/phantom_camera/phantom_camera_3D.gd

  Line 558 in eac94c2

  look_at(_look_at_target_node.get_position() + look_at_target_offset)

• phantom-camera/addons/phantom_camera/scripts/phantom_camera/phantom_camera_3D.gd

  Line 562 in eac94c2

  look_at(_look_at_group_nodes[0].get_position())

• phantom-camera/addons/phantom_camera/scripts/phantom_camera/phantom_camera_3D.gd

  Line 564 in eac94c2

  var bounds: AABB = AABB(_look_at_group_nodes[0].get_position(), Vector3.ZERO)

• phantom-camera/addons/phantom_camera/scripts/phantom_camera/phantom_camera_3D.gd

  Line 566 in eac94c2

  bounds = bounds.expand(node.get_position())

[ramokz]

Good spot! Have submitted another hotfix to address those.
That'll also teach me to not submit fixes during lunch breaks...

Thanks again!

[m4rr5]

You're welcome again! :)