Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header regex is too restrictive #304

Open
GregoryJSharp opened this issue Jun 14, 2023 · 1 comment
Open

header regex is too restrictive #304

GregoryJSharp opened this issue Jun 14, 2023 · 1 comment

Comments

@GregoryJSharp
Copy link

In hey.go, the headerRegexp only allows \w and - in the header name.
According to RFC 7230, section 3.2, a header field name can be a "token".
According to 3.2.6, a token is one or more characters in
\w ! # $ % . & ' * + - ^ ` | ~
and possibly a few other things.

@ta924
Copy link

ta924 commented Jul 14, 2023

@rakyll being that you are the owner of the repo, I was curious is this begin actively monitored? I see the last commit has been quite some time back and multiple PRs are waiting. We are trying to understand if they will be evaluate or if forking this repo and expanding upon it is the recommended approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants