-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to Action in the footer #29
Comments
hi @siddhant36 Right now we don't have a footer. So do you mind making a footer and adding the CTA's? |
@everly-gif Yes, I will add a footer section for the portfolio which will match the template's style and contain all the CTA buttons. Please assign me this task |
@siddhant36 go ahead! |
@everly-gif I have made the PR request containing Footer with CTA. Please have a look and let me know if it served the cause. |
@Pranjal7852 Issues are given first come first serve basis. @siddhant36 claimed it before you and hence only his PR can be accepted with this issue. Please refer the README.md and follow that from next time :) However, if he is unresponsive then we can reassign it to you and your PR can be accepted. |
@siddhant36 please submit the PR within today by the end of the day. Will be reassigning it tomorrow to @Pranjal7852 if no progress @rajmunkhan keep up with this issue's progress and reassign it tomorrow if necessary. |
@Pranjal7852 this issue is assigned to u, r u up for it? I saw your PR but it has some conflicts, also I need some changes there, can we talk about it? |
I am ready to work do let me know the changes to be made |
from this deesign, remove the connect with me H2, keep only the icons, and also don't keep the icons so separated from each other. Keep them closer in middle. |
@rajmunkhan I have the changes as per your request do check it out. |
@Pranjal7852 it looks cool but your PR has conflicts, do u know how to fix them? The steps are:
|
I will try my best |
Sorry was inactive due to some personal reasons. Getting back to work now could I still take part in solving any other issue @rajmunkhan . I would like to contribute to the portfolio project |
@everly-gif There should be a call to action of Email id and phone number. If we click on any of these it should redirect to the respective apps. Please assign me to take up this task
Reference of mine:
The text was updated successfully, but these errors were encountered: