Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update USWDS to resolve SASS deprecations #3334

Open
5 tasks
jtimpe opened this issue Dec 3, 2024 · 1 comment
Open
5 tasks

Update USWDS to resolve SASS deprecations #3334

jtimpe opened this issue Dec 3, 2024 · 1 comment
Labels
Blocked Label for Pull Requests that are currently blocked by a dependency dev

Comments

@jtimpe
Copy link

jtimpe commented Dec 3, 2024

Description:
#1577 upgraded react-scripts to version 5, along with most other frontend dependencies.

After the upgrade, some deprecations are being reported by SASS, resulting from the USWDS library.

<w> Deprecation color.lightness() is deprecated. Suggestion:
<w> 
<w> color.channel($color, "lightness", $space: hsl)
<w> 
<w> More info: https://sass-lang.com/d/color-functions
<w> 
<w> node_modules/@uswds/uswds/packages/uswds-core/src/styles/mixins/helpers/checkbox-and-radio-colors.scss 68:5  -checkbox-and-radio-colors()
<w> node_modules/@uswds/uswds/packages/uswds-core/src/styles/mixins/helpers/checkbox-and-radio-colors.scss 12:3  checkbox-colors()
<w> node_modules/@uswds/uswds/packages/usa-checkbox/src/styles/_usa-checkbox.scss 5:1                            @forward
<w> node_modules/@uswds/uswds/packages/usa-checkbox/src/styles/_index.scss 4:1                                   @forward
<w> node_modules/@uswds/uswds/packages/usa-checkbox/_index.scss 8:1                                              @forward
<w> node_modules/@uswds/uswds/packages/uswds-form-controls/_index.scss 4:1                                       @forward
<w> node_modules/@uswds/uswds/packages/uswds/_index.scss 51:1                                                    @forward
<w> src/index.scss 3:1                                                                                           root stylesheet

USWDS has the following issue open, which reflects this deprecation

Once the deprecations are resolved in the USWDS library, we need to update to the latest version.

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • Warning shown above no longer displayed during compilation
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Update USWDS once linked issue is resolved in newer version
  • Run Testing Checklist and confirm all tests pass

Notes:

  • This is an open issue for the library, no possible action presently available to us.

Supporting Documentation:

Open Questions:

@jtimpe jtimpe added the dev label Dec 3, 2024
@lhuxraft
Copy link
Collaborator

lhuxraft commented Dec 10, 2024

Update issue to blocked. Wait to point until issue is resolved by USWDS

@lhuxraft lhuxraft added Blocked Label for Pull Requests that are currently blocked by a dependency Refined Ticket has been refined at the backlog refinement and removed Refined Ticket has been refined at the backlog refinement labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Label for Pull Requests that are currently blocked by a dependency dev
Projects
None yet
Development

No branches or pull requests

2 participants