Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

Feature Request & Improvements #5

Open
MuhammadBayiz opened this issue Jul 13, 2023 · 17 comments
Open

Feature Request & Improvements #5

MuhammadBayiz opened this issue Jul 13, 2023 · 17 comments

Comments

@MuhammadBayiz
Copy link

Hi! This project is really great and i love it.
I got a couple of suggestions on it:

  • Add Movie Calendar as a separate iCalendar
  • Add the Streaming Platform in the location

Example
Screenshot_20230713-204131_Calendar

  • improve The Event Time by using the Episode/Movie Runtime

Example
Screenshot_20230713-204403_Calendar

@radityaharya
Copy link
Owner

  • Add Movie Calendar as a separate iCalendar

I'm planning to do this eventually

  • Add the Streaming Platform in the location

Example
Screenshot_20230713-204131_Calendar

Yes!, I wanted to include this as well. But as far as I know Trakt's API doesn't provide streaming platform info but it does include ids to tmdb and tvdb. I'll try to hook it up

  • improve The Event Time by using the Episode/Movie Runtime

Example
Screenshot_20230713-204403_Calendar

I've implemented it on the latest commit. Should be up and working

@MuhammadBayiz
Copy link
Author

Great, thanks for the consideration ^⁠_⁠^

@MuhammadBayiz
Copy link
Author

And also one little change:
Add a dash between the tv name and the Season Episode Number to separate them easily

Example
Screenshot_20230714-084301_Calendar

@radityaharya
Copy link
Owner

Add Movie Calendar as a separate iCalendar

Add a dash between the tv name and the Season Episode Number to separate them easily

Added both on the latest commit, give it a go :D

@MuhammadBayiz
Copy link
Author

Sorry for late reply, I checked and it works very well ^⁠_⁠^
Screenshot_20230718-160937_Calendar
I do have a suggestion though, for the movie you could add the year in a parenthesis like so
Screenshot_20230718-160711_Calendar

Thanks for your efforts i really appreciate it, and i think this project is fantastic and definitely more users will use it once they find it ;) (btw i found it by a very fortunate accident while i was searching im Google)

@MuhammadBayiz
Copy link
Author

Also for the runtime, does you have to call tmdb api for it or trakt provide it itself?

@radityaharya
Copy link
Owner

Thanks for your efforts i really appreciate it, and i think this project is fantastic and definitely more users will use it once they find it ;) (btw i found it by a very fortunate accident while i was searching im Google)

Thank you for your kind words! I’m glad you found this project helpful.

Also for the runtime, does you have to call tmdb api for it or trakt provide it itself?

It's provided by Trakt. As far as I know, Trakt is in the process of migrating their metadata from TVDB to TMDB, so it could be a hit or miss for some niche shows/movies. Probably should set a fallback for those that doesn't have a runtime data.

@MuhammadBayiz
Copy link
Author

It's provided by Trakt. As far as I know, Trakt is in the process of migrating their metadata from TVDB to TMDB, so it could be a hit or miss for some niche shows/movies. Probably should set a fallback for those that doesn't have a runtime data.

Oh, some indeed has approximate runtimes if that's so then i guess it will be resolved soon. :)

@radityaharya
Copy link
Owner

I do have a suggestion though, for the movie you could add the year in a parenthesis like so

Added!

@MuhammadBayiz
Copy link
Author

Awesome, Should i grab a new link or the calendar will update after 8 hours?

@radityaharya
Copy link
Owner

Awesome, Should i grab a new link or the calendar will update after 8 hours?

it should pull the latest feed automatically, but you can unsubscribe and resubscribe using the same link if you want to

@MuhammadBayiz
Copy link
Author

If i resubscribe won't that cache my previous calendar and create another or it will replace the older one according to the trakt account?

@radityaharya
Copy link
Owner

If i resubscribe won't that cache my previous calendar and create another or it will replace the older one according to the trakt account?

I'm pretty sure it'll just fetch the latest one. I don't think Google caches feeds within the same url, and the cache I'm using is stored on disk so every time I commit to master it should purge everything as Its being rebuild on Railway

@MuhammadBayiz
Copy link
Author

Sorry i mean being called on your server, last night i tried an old url from a week ago with old commits and it was still working, i was surprised that it wasn't getting deleted from your server.
What I'm concerned about is that if your server caches old commits and sync them won't that just put a huge load on the server for no good reason?

@radityaharya
Copy link
Owner

Sorry i mean being called on your server, last night i tried an old url from a week ago with old commits and it was still working, i was surprised that it wasn't getting deleted from your server. What I'm concerned about is that if your server caches old commits and sync them won't that just put a huge load on the server for no good reason?

The cache should invalidate every hour and fetch new feed from trakt for every request only if the cache haven't expire.

But I might have messed something up and currently the caching doesn't work

@MuhammadBayiz
Copy link
Author

Man this is awesome!! *0*/
Screenshot_20230722-002532_Calendar
Now even the location is set for the shows! The runtime is mostly right except for movies and the little tweaks are done. Thanks man this is great.
The location doesn't show for movies is that a working progress or a bug? Beside that it feels pretty good

@radityaharya
Copy link
Owner

The location doesn't show for movies is that a working progress or a bug? Beside that it feels pretty good

I'm currently using the "Networks" information for the TV Series. TMDB does provide endpoints both for TV and Movies streaming platforms, but as we know availability differs between regions. What i'm planning is to add an additional ui element for users to select which streaming platforms they have access to, sort their priority to be displayed on the calendar and selecting region either from the ui or based on IP geolocation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants