Skip to content
This repository has been archived by the owner on Dec 30, 2021. It is now read-only.

Settings page #3

Open
chrismou opened this issue Jun 7, 2016 · 6 comments
Open

Settings page #3

chrismou opened this issue Jun 7, 2016 · 6 comments
Labels
Milestone

Comments

@chrismou
Copy link
Member

chrismou commented Jun 7, 2016

Need a generic, tabbed (?) settings page.

Ideally accessible via the context menu, but I guess we're not tied that that if we have a better idea!

Note - if anyone fancies taking this on but doesn't fancy tackling the styling, feel free to add the functionality and ping me and I'll pretty it up.

@chrismou chrismou added the core label Jun 7, 2016
@chrismou chrismou added this to the First Release milestone Jun 7, 2016
@jacobwgillespie
Copy link
Member

We should check out https://github.com/gabrielbull/react-desktop - prebuilt react components with a native look / feel for OSX and Win10.

@jacobwgillespie
Copy link
Member

And we also need to implement a persistence layer with one of the existing solutions (there are several existing modules that coordinate a backing JSON file for app settings - we should pick one) and wire it up to the IPC framework.

@chrismou
Copy link
Member Author

chrismou commented Jun 7, 2016

Ah jeez, don't be forgetting the linux lot. You'll get some serious grief if you do 😉

@matthewdias
Copy link

They're just react components, so technically they would work with Linux. They're just not gonna integrate with gtk or anything so it would look out of place. An alternative could be to do one in a page in the app, similar to how GPMDP does it?

@jacobwgillespie
Copy link
Member

One note on Win10 / Linux - thus far I have written the app to target only OSX since the immediate target is to replace Radiant 1.x. The keyboard shortcuts, menu items, and some window behaviors expect OSX, and most importantly, the custom title bar uses a native (C++) interface to the system mouse events so that it can performantly implement the drag regions, and that native module only works on OSX.

So, if / when we decide to go cross-platform, those elements will need to be conditionally modified to behave as expected on the other platforms, and the mouse module will need to be rewritten for Windows and Linux in addition to theming considerations like the settings dialog.

@jacobwgillespie
Copy link
Member

That mouse stuff is issue #2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants