-
Notifications
You must be signed in to change notification settings - Fork 8
Back button #11
Comments
Back / forward are already implemented as keyboard shortcuts, just need to get their state into the shared redux store and add buttons to the custom titlebar. |
from what I can tell theyre already in the store via menu.js? If i tried to tackle this, what would be the best method to insert the buttons in the webview? Or should I just put them in the titlebar? They would look kind of out of place to the left of the hamburger menu. |
The buttons are there yes, but the state of https://github.com/electron/electron/blob/master/docs/api/web-view-tag.md#webviewcangoback I would either add the buttons to the titlebar and somehow detect when the menu opens on GPM to dynamically move / hide them, or I would extend the |
Ah I didnt see that module. That indeed sounds like the better option. |
I should probably update the README / docs to better cover what's already been written. 😃 |
Implement a back button for navigating back from within the player.
For bonus points, also implement a forward button (as Radiant v1 currently has)
The text was updated successfully, but these errors were encountered: