Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json input file from Android Chromium browser, wrong file structure #191

Closed
Guybrush3pw00d opened this issue May 2, 2024 · 4 comments
Closed
Labels
question Further information is requested

Comments

@Guybrush3pw00d
Copy link

Guybrush3pw00d commented May 2, 2024

My best regards. I've been using Adblock browser (a Chromium browser for Android) for long and I wanted to export its bookmarks. Unfortunately, it has the feature disabled unlike other Chromium browsers available for Android (one ot the reasons behind the switch) so I've manually saved the bookmarks file (bookmarks_unedited.json).
It clearly seems to me a json but bookmarks-converter doesn't accept it as valid. I've then checked the expected file structure here and have found out that it isn't the same so I've tried to edit the original file obtaining bookmarks.json but it still complains.
I've then found this javascript (thanks to one of the advices given here) which has worked like a charm solving my problem but I'd still like to understand what I'm doing wrong here, clearly not an issue with bookmarks-converter itself and I care about underlining it.
Thanks in advance and have a nice day!! :)

@Guybrush3pw00d Guybrush3pw00d changed the title json format wrong json input file from Android Chromium browser, wrong file structure May 2, 2024
@radam9
Copy link
Owner

radam9 commented May 4, 2024

Hey @Guybrush3pw00d
The modified version you have upload bookmarks.json doesn't fully follow the standard chrome bookmarks syntax.
I tried to download bookmarks_unedited.json to check which errors you are getting, but I can't download that one.

If you could re-upload that file, I could check what the problem is for you.
or if you could provide what kind of errors you are getting I could try to walk you through what the problem is.

@radam9 radam9 added the question Further information is requested label May 4, 2024
@Guybrush3pw00d
Copy link
Author

Guybrush3pw00d commented May 6, 2024

First of all, thanks for your kind follow-up and apologies for not replying before. I don't know how it could happen, given that everything had gone fine with no errors with the previous upload too but I've just reuploaded the bookmarks_unedited.json. It is the file as taken from AdBlock browser profile folder and it is even worse than the version edited by me as it contains much more attributes not adehering to the structure in the docs.
It's clear it isn't just that: probably there is something deeper in the json structure too, given that just removing those extra attributes as I've already done wasn't enough.
The error I get is just that the file isn't a valid json. I thought I had already said it.
Thanks again and have a nice day. :)

@radam9
Copy link
Owner

radam9 commented May 10, 2024

@Guybrush3pw00d, there was a small bug due to the meta_info field.
I fixed that and released a new version, now it should work as intended with the original file you extracted from your browser.

@radam9 radam9 closed this as completed Jun 3, 2024
@Guybrush3pw00d
Copy link
Author

Guybrush3pw00d commented Jun 8, 2024

First of all thanks for your effort and please accept my sincere apologies for not coming back before with a confirmation. The reason was that I had tried quite promptly but I was getting the same outcome than before.
I've then choosen to refresh my environment to be on the safe side and avoid making a false report. This has taken some time and I couldn't before. I can confirm that everything works like a charm. Thanks, really a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants