Refactoring qf_cauer and adding tee types #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A simple schematic showing a band pass filter before and after this pull request: components values are identical. |
|
Thanks for the contribution! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tee types cauer filters following #670, correcting some display issues and refactoring qf_filter for better encapsulation of signal processing logic.
Correcting multiple bugs:
1)The one in #670 where pi-type is given when selecting tee-type.
2) Wrongly wired capacitor in cauer band-pass and band-stop filters
3) Tee-type generated when trying to generate a pi-type high-pass filter