Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested class sequences are not flattened #203

Open
zlorf opened this issue Jul 8, 2019 · 0 comments
Open

Nested class sequences are not flattened #203

zlorf opened this issue Jul 8, 2019 · 0 comments

Comments

@zlorf
Copy link

zlorf commented Jul 8, 2019

Recently we upgraded our dependencies, switching from sablono 0.7.1 to 0.8.6.

And because of 17ec99d, some our code stopped working.

That is because previously (join-classes ["a" ["x" ["y"]]]) returned
"a x y"
and now
"a x [\"y\"]"

flatening happens only at the first level, what is problematic, when you have something like

(html [:div.a {:class [(if foo "x") (get-classes)]}])

where get-classes returns a dynamic list/vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant