This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
feat: flag and config to skip notifications #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of a run, topgrade normally sends a system notification. This change adds a command-line flag and a config-file option to disable this behaviour.
Also derive Eq where PartialEq is being derived. https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
|
Hi there @r-darwish! Is there anything else I can do to help get this merged/released? |
kimlindberg
approved these changes
Oct 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of a run, topgrade normally sends a system notification.
This change adds a command-line flag and a config-file option to disable this behaviour.
Fixes #936.
Standards checklist:
cargo build)cargo fmt)cargo clippy)cargo test)If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.