Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant code from resolve_quickemu() #1404

Merged
merged 2 commits into from
Sep 30, 2024
Merged

refactor: remove redundant code from resolve_quickemu() #1404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa71687
fix: remove redundant command call
philclifford Jul 5, 2024
58d7cb9
fix: test local quickemu is executable
philclifford Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions quickget
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3361,10 +3361,9 @@ function create_config() {

# Use command -v command to check if quickemu is in the system's PATH and
# fallback to checking if quickemu is in the current directory.
function resolve_quickemu() {
if command -v quickemu >/dev/null 2>&1; then
command -v quickemu
elif [ -f "./quickemu" ]; then
function resolve_quickemu() {
command -v quickemu || \
if [ -x "./quickemu" ]; then
echo "$(pwd)/quickemu"
else
echo "quickemu not found" >&2
Expand Down