refactor: remove redundant code from resolve_quickemu() #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexiondotorg
changed the title
flexiondotorg
changed the title
flexiondotorg
changed the title
flexiondotorg
requested changes
Aug 27, 2024
philclifford
force-pushed
the
fix-refactor-resolve
branch
from
d29e76c to
58d7cb9
Compare
flexiondotorg
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve_quickemu has inelegant test logic with redundant duplicate usage of
command. This refactors resolve_quickemu slightly to remove the redundancy. It also changes the local fallback test to look for an executable file rather than just a file.Type of change
Checklist: