Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests CI and refactor release workflow #1155

Merged
merged 25 commits into from
May 3, 2024
Merged

Add tests CI and refactor release workflow #1155

merged 25 commits into from
May 3, 2024

Conversation

flexiondotorg
Copy link
Member

No description provided.

@zen0bit
Copy link
Contributor

zen0bit commented May 3, 2024

@zen0bit
Copy link
Contributor

zen0bit commented May 3, 2024

Also why you changed my use of shellcheck lint?
My was universal solution for both PRs and push suggestions...
And reviewdog can also be runned localy...

@zen0bit
Copy link
Contributor

zen0bit commented May 3, 2024

Why are you trying recreate what I already did? Just merge my update pack and then your icons...

Everyhing you want is already there, rest is gone

Biggest flaw here is lack of communication from your side... 🥲

@zen0bit
Copy link
Contributor

zen0bit commented May 3, 2024

Also don't see any daily-live ISOs there...
Also repaired

And shellcheck also

You broke it even more than I did 🤣

@zen0bit
Copy link
Contributor

zen0bit commented May 3, 2024

#1107

@zen0bit
Copy link
Contributor

zen0bit commented May 3, 2024

Please don't do refactors for the sake of change on my code

@flexiondotorg flexiondotorg merged commit e4c6121 into master May 3, 2024
5 of 6 checks passed
@flexiondotorg flexiondotorg deleted the ci branch May 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants