Hibernate ORM multi-tenancy quickstart is outdated (and broken)

[yrodiere]

Description

There are several problems with this quickstart: https://github.com/quarkusio/quarkus-quickstarts/tree/main/hibernate-orm-multi-tenancy-quickstart

1. It's hard to use. It uses schema multi-tenancy by default, and requires weird profile setting to use database multitenancy instead. Even when using the default, one needs to start the DB manually with docker compose instead of just using dev services.
2. Database multitenancy is simply broken. Following instructions will result in dev services starting up for the default database, and failing to bind to port 5432.

Implementation ideas

1. Let's split examples between schema multitenancy in one project, and database multi tenancy in the other.
2. Let's use dev services everywhere. I'm pretty sure we don't need docker-compose nowadays, and can set DB init scripts in dev services instead. See how it's done in Quarkus integration tests, maybe?
3. Maybe, let's also provide a quickstart for discriminator multi-tenancy.
4. Let's link to these quickstarts from the documentation.

[quarkus-bot]

/cc @gsmet (hibernate-orm)

[tobHai]

Hi!

I would like to provide a PR for this issue.
I already started to clean up the quick-start here.

[yrodiere]

Hi! Thank you for contributing. Please send a PR when you're ready :)
I think you should be able to enable GitHub Actions in your fork, that way you can check the build actually passes even before sending the pull request.

[yrodiere]

By the way:

Let's split examples between schema multitenancy in one project, and database multi tenancy in the other.

This was not about removing the database multitenancy quickstart, but about keeping it in a separate project from schema multitenancy. Seems you removed it :)

[tobHai]

Alright, thanks 😄
Yes, my plan was to remove the database multi tenancy code from the current quick start first and then create a separate project for that - but thanks for pointing that out. 😄

[tobHai]

@yrodiere unfortunately I'm having some issues with the Github Actions in my fork.
For testing purposes I created a simple PR containing only a small change in the README file, but the build is failing:
tobHai/quarkus-quickstarts#2
I used the development branch as a base branch since the contribution guide states that all contributions should target the development branch, is that correct?

Thanks in advance!

[yrodiere]

I used the development branch as a base branch since the contribution guide states that all contributions should target the development branch, is that correct?

Yes!

For testing purposes I created a simple PR containing only a small change in the README file, but the build is failing:
tobHai/quarkus-quickstarts#2

Your branch seems based on the development branch as of a few days ago, and it seems the build was failing then, but a few PRs have been merged recently to fix that.

Try rebasing on the current head of the development branch?

[tobHai]

@yrodiere thanks!

The MR is ready: quarkusio/quarkus-quickstarts#1493