-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search doesn't do anything on ja.quarkus.io #1104
Comments
Interestingly:
|
Thank you for pointing this out.
For most parts, files are parsed and sentences are replaced automatically, but in some HTML template files, templates contain template directives and they prevent the HTML parser to process the template files. Some localized sites that already translated HTML templates are affected, and other localized sites that haven't translated HTML templates are not affected. |
Update outdated html templates to address #1104
Now the search starts working on ja.quarkus.io. Thank you for adding this awesome feature! |
Thanks for fixing this! |
I'm not sure why, but the changes to quarkusio/quarkusio.github.io#1825 seem to have been taken into account only partially on localized websites. Search on this page doesn't do anything: https://ja.quarkus.io/guides/
I thought localized sites were using the same HTML, just with text content replaced with translations, but it would seem that assumption was wrong; some of the HTML gets overridden, too?
In particular I have this structure on Quarkus.io (and we've had that structure since early last week, so before the last sync):
But on ja.quarkus.io we have this:
See also https://github.com/quarkusio/quarkusio.github.io/blob/317cacbcd097a4f51c7ac4f895c3b9a3759f7cac/guides/index.html#L135-L153 vs.
ja.quarkus.io/docs/guides/index.html
Lines 136 to 148 in 98dc257
Do you have any idea what's going on, @ynojima?
The text was updated successfully, but these errors were encountered: