Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to execute APK's methods in Quark Script #583

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haeter525
Copy link
Member

@haeter525 haeter525 commented Nov 23, 2023

Close #582.

The PR adds two Quark Script APIs, getInstances and execute, to support executing APK's method with custom arguments.

@pep8speaks
Copy link

pep8speaks commented Nov 23, 2023

Hello @haeter525! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-23 16:07:22 UTC

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ccf2282) 78.29% compared to head (f207dd1) 78.57%.
Report is 3 commits behind head on master.

Files Patch % Lines
quark/script/objection.py 83.63% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   78.29%   78.57%   +0.27%     
==========================================
  Files          64       64              
  Lines        5280     5391     +111     
==========================================
+ Hits         4134     4236     +102     
- Misses       1146     1155       +9     
Flag Coverage Δ
unittests 78.57% <92.80%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Quark Script API to support executing the APK's methods
3 participants