-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org.apache.log4j.helpers.Loader.isJava1() returns true on Java 19 and other versions #59
Comments
HI @pburka, The May I ask how come you came to find about this issue? |
I've hit problems with |
Commit 3f35d07 cleans up the code. This was incorporated into release reload4j 1.2.24. |
FYI The fix for this caused this problem: #62 |
If the Java version string doesn't include a decimal point, reload4j incorrectly identifies it as Java 1. The initial version of each major release no longer includes a decimal point (since around Java 10 or 11), so reload4j incorrectly identifies these as Java 1 (circa 1995).
The simplest fix would be to make
isJava1()
always return false, since the reload4j website indicates that build targets Java 1.5, so the classfiles won't even work on Java 1.The text was updated successfully, but these errors were encountered: