[Potential Bug] With customizable layer_state_t, layers shifting might not work.

[alex-ong]

I'm still investigating, but i'm back on optimizing layer_state_t.

Describe the Potential Bug

Commit: b62e160
added LAYER_STATE_8BIT, LAYER_STATE_16BIT and LAYER_STATE_32BIT.

However this will have a flow on effect in action_layer.c

Layer Shifting might not work due to assumption of uint_32t in layer shifting code.

Additional Context

This was previously discussed in TMK under issue #526
tmk/tmk_keyboard#526

[alex-ong]

I can't seem to make it break;
i tried LAYER_STATE_8BIT, and defined layers 0 and 7 with an MO(7).

If someone can confirm that the code 110% works we can close the issue that isn't a real issue:

existing code (action.c):

uint8_t shift = action.layer_bitop.part * 4;

theoretical correct code:

#if defined(LAYER_STATE_8BIT)
    return (action.layer_bitop.part & 1) * 4;
#elif defined(LAYER_STATE_16BIT)
    return (action.layer_bitop.part & 3) * 4;
#else    
    return action.layer_bitop.part * 4;
#endif

[zvecr]

This issue has been automatically closed because it has not had any recent activity.
If this issue is still valid, re-open the issue and let us know.