Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new primitive based algorithms. #425

Closed
4 tasks done
woodsp-ibm opened this issue Oct 13, 2022 · 5 comments
Closed
4 tasks done

Support new primitive based algorithms. #425

woodsp-ibm opened this issue Oct 13, 2022 · 5 comments
Assignees
Milestone

Comments

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Oct 13, 2022

What is the expected enhancement?

Support primitive based algorithms such as the new QAOA and SamplingVQE etc accordingly.

Update GroverOptimizer to move away from QuantumInstance use, potentially by more directly using Grover from Terra.

Update tutorials correspondingly

Update readme sample

Migration guide as applicable

@t-imamichi
Copy link
Collaborator

Tutorials and migration guide have just been merged #448. So, I think we can close this issue.

@woodsp-ibm
Copy link
Member Author

So, I think we can close this issue.

Yes. I think so.

Maybe though, if you note above I mentioned for the GroverOptimzer the direct use of Grover algorithm from Terra. When the GroverOptimzer was originally done the Grover at that time was not as flexible. But now its likely that the Grover algorithm can be used here rather than the custom logic/circuits here. There was no time to look into this though for the current release but it may be worth raising a separate issue to cover this so it can be looked at later.

@t-imamichi
Copy link
Collaborator

Thank you for reminding me of GroverOptimizer. Is this https://github.com/Qiskit/qiskit-optimization/pull/437/files#r1024573314 the discussion?

@woodsp-ibm
Copy link
Member Author

That certainly was the most recent discussion, yes. The idea has been floating around for a while though.

@t-imamichi
Copy link
Collaborator

I made #456 for the discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants