-
-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python refactoring? #99
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the python component is... a bit quirky.
The a few things I've found which seem sort of easy to fix if your interested in getting PRs for each of them:
app.py
getting transformed into__main__.py
and the__init__.py
being echoed into the python package from a shell script, definitely resulted in several minutes of confusion looking for the python library code (which I'd like to be able to save other devs in future)app.py
and JavaScriptapp.js
seems like it could be improved but that would require one to depend on the other.re.compile()
(import aliasedfrom re import compile as recompile
) during class init instead of as part of a module load__main__.py
makes it more challenging to read and understand things than it needs to be.if
conditions to remove unnecessary use ofpass
and putting the actually desired output inside theelse
I suppose the TLDR is... There's quite a lot of refactoring opportunities in the python code (and the python packaging) but the code also looks like it has a very personal style, so if you would prefer to not have significant refactoring PRs submitted, then it would be good to know before I went ahead and wrote one, or multiple 😅
The text was updated successfully, but these errors were encountered: