Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Output thousands of lines when WebUI or healthcheck server port been used by another program. #720

Closed
Cassy-Lee opened this issue May 14, 2024 · 1 comment

Comments

@Cassy-Lee
Copy link

TLDR: Output thousands of lines when WebUI or healthcheck server port been used by another program.

  1. Is this urgent: No
  2. DNS provider(s) you use: unnecessary
  3. Program version:
    Running version 2.6.0 built on 2024-02-03T18:57:00Z (commit c338c28ce3ab3aa9948f0fe133307b75fe6d34d2)
  4. What are you using to run the container: using zero-dependency binary
  5. Extra information (optional)
    Host OS: linux aarch64

Simple solutions:
Give options to disable unnecessary features(WebUI and health server). Such as "DISABLE_WEBUI" and "DISABLE_HEALTH_SERVER" environment variables.
Add retry limit for server restart to avoid spam.

Suggestions:
Allow some configs in the config file, not only command line and environment variables.
Remove (or disable) features for dockers in the standalone binary.

@qdm12
Copy link
Owner

qdm12 commented Jun 13, 2024

Remove (or disable) features for dockers in the standalone binary.

Done in 776206e - the healthcheck server won't run when outside Docker 😉

Add retry limit for server restart to avoid spam.

This is solved from commit 130ab00 where a critical error terminates the whole program. Only the backup service is auto-restarted (to zip config.json and updates.json).

Give options to disable unnecessary features(WebUI and health server)

I don't think anyone would want to disable the web ui or the health server when in Docker really, since they can just not publish ports etc. I have however added SERVER_ENABLED in cc995a7 to disable the http server (web ui) when running outside Docker since it could get handy.

@qdm12 qdm12 closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants