Updated The YAST to Go Version 1.19 #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with '#' will be ignored, and an empty message aborts the commit. On branch main Your branch is up to date with 'origin/main'. Changes to be committed: modified: go.mod modified: go.sum
On branch main Your branch is up to date with 'origin/main'. Changes to be committed: modified: go.mod modified: go.sum
qascade
requested changes
Oct 2, 2022
|
Once you are done with the same. I will pull the branch and check locally. If everything looks fine. I will merge the PR. Thanks. |
On branch main Your branch is up to date with 'origin/main'. Changes to be committed: modified: .github/workflows/CI.yml modified: .github/workflows/test.yml
|
@Hirdey-1999 the checks are failing. Can you run |
On branch main Your branch is up to date with 'origin/main'. Changes to be committed: modified: config/buildspec.go modified: main.go modified: query/query.go modified: tests/scraper_test.go modified: tui/choices.go modified: tui/listmodel.go modified: tui/setupmodel.go modified: ui_tests/listmodel_test.go
qascade
approved these changes
Oct 7, 2022
|
Hey, I noticed that you did the changes on the main branch and made a PR. That is not allowed as per yast branching rules and contibution guidelines, can you shift the changes to another branch and make another PR. Also, I don't know but somehow |
|
Closing this PR for now. Please make another PR whenever you get time. I'll approve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAST Project has been Updated to 1.19
Changes made to