-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bc break] Remove the IPageFactory interface #120
Comments
Technically public method declaration change, that are using I'm not sure however about version number change like this. |
Do we still keep this in 1.1 or move it to 2.x? You are right about the BC break and in this case the major version should increase. |
Tricky subject. I double anybody is implementing this interface in their custom factories or using it for typehinting. But regardless other class (using factory) constructor signature would change and since it's public this is bc break for sure. |
Originally the
IPageFactory
interface was designed to allow people to create page factories that use different (not annotation-based) means for specifying element/block selectors.To my knowledge only other possible implementation of
IPageFactory
interface would be like in BehatPageObjectExtension (see http://behat-page-object-extension.readthedocs.org/en/latest/guide/working_with_elements.html), where instead of class properties with selectors defined as annotations there is an$elements
array property where you define each element (key) and it's selector (value).To finalize I believe that annotation-based approach is core of the library and this should be stressed out by:
IPageFactory
interfaceIPageFactory
interface toPageFactory
classThe text was updated successfully, but these errors were encountered: