Marked the std streams as possibly be None #11826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Looking at the primer output: With the exception of cwltool (and streamlit, where only the error message has changed), these are all unintended, but positive side-effects of this change. In all cases, valid objects that were not derived from The cwltool tests assign a string to the streams. This is now unfortunately a false negative, but still worth it, in my opinion. |
mondeja
reviewed
Apr 29, 2024
|
Good catch. I will try using regular |
|
Diff from mypy_primer, showing the effect of this PR on open source code: rich (https://github.com/Textualize/rich)
+ rich/console.py:93: error: Item "None" of "TextIOWrapper | None" has no attribute "fileno" [union-attr]
+ rich/console.py:97: error: Item "None" of "TextIOWrapper | None" has no attribute "fileno" [union-attr]
+ rich/console.py:101: error: Item "None" of "TextIOWrapper | None" has no attribute "fileno" [union-attr]
- rich/live.py:180: error: Subclass of "TextIO" and "FileProxy" cannot exist: would have incompatible method signatures [unreachable]
- rich/live.py:183: error: Subclass of "TextIO" and "FileProxy" cannot exist: would have incompatible method signatures [unreachable]
pytest (https://github.com/pytest-dev/pytest)
+ src/_pytest/capture.py:204: error: Item "None" of "TextIOWrapper | None" has no attribute "encoding" [union-attr]
+ src/_pytest/faulthandler.py:65: error: Item "None" of "TextIOWrapper | None" has no attribute "fileno" [union-attr]
tornado (https://github.com/tornadoweb/tornado)
+ tornado/test/runtests.py:174: error: Unused "type: ignore" comment [unused-ignore]
werkzeug (https://github.com/pallets/werkzeug)
- tests/test_debug.py:196: error: Incompatible types in assignment (expression has type "HTMLStringO", variable has type "TextIO") [assignment]
- tests/test_debug.py:199: error: "TextIO" has no attribute "reset" [attr-defined]
- tests/test_debug.py:201: error: "TextIO" has no attribute "reset" [attr-defined]
- tests/test_debug.py:213: error: Incompatible types in assignment (expression has type "HTMLStringO", variable has type "TextIO") [assignment]
- tests/test_debug.py:216: error: "TextIO" has no attribute "reset" [attr-defined]
scrapy (https://github.com/scrapy/scrapy)
+ scrapy/utils/log.py:117: error: Unused "type: ignore" comment [unused-ignore]
cwltool (https://github.com/common-workflow-language/cwltool)
+ tests/test_context.py:17: error: Unused "type: ignore" comment [unused-ignore]
+ tests/test_context.py:18: error: Unused "type: ignore" comment [unused-ignore]
streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/web/bootstrap_test.py:107:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:107:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:131:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:131:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:153:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:153:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:177:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:177:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:201:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:201:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:221:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:221:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:245:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:245:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:270:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:270:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:295:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:295:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:312:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:312:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:333:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:333:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
- lib/tests/streamlit/web/bootstrap_test.py:342:15: error: "TextIO" has no attribute "getvalue" [attr-defined]
+ lib/tests/streamlit/web/bootstrap_test.py:342:15: error: Item "TextIO" of "Union[TextIO, Any]" has no attribute "getvalue" [union-attr]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11778