Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logging.lastResort #11770

Closed
edyounis opened this issue Apr 16, 2024 · 2 comments
Closed

Change logging.lastResort #11770

edyounis opened this issue Apr 16, 2024 · 2 comments
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome stubs: false positive Type checkers report false errors

Comments

@edyounis
Copy link
Contributor

The last resort handler in logging should be a generic Handler rather than a stream handler.

In the Python logging documentation, it refers to the lastResort handler as a handler in one sentence and a StreamHandler in another. It is set to a StreamHandler by default, but setting it to another type of Handler works without issue in practice.
@srittau
Copy link
Collaborator

srittau commented Apr 24, 2024

Makes sense, PR welcome!

@srittau srittau added stubs: false positive Type checkers report false errors help wanted An actionable problem of low to medium complexity where a PR would be very welcome labels Apr 24, 2024
@edyounis edyounis mentioned this issue May 7, 2024
Merged
@srittau
Copy link
Collaborator

srittau commented May 7, 2024

Fixed in #11872

@srittau srittau closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome stubs: false positive Type checkers report false errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srittau @edyounis